Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports custom reagents and recipes #539

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Bribrooo
Copy link
Contributor

About the PR

Adds a bunch of RP-meds, a lot of complex synthesis processes, and a shit ton of reagents.

Why / Balance

Originally made for Delta-V, I've been a fan of the original concept of making RP-oriented medicine.
With the help of a real pharmacist and my own extensive research for 7 months on the subject, this is as close as I can recreate the synthesis of pharmaceuticals in Space Station 14 with the best of my knowledge on coding.

  • Asparatine - mild painkiller
    • Sodium Salicylate
      • Methyl Salicylate
        • Salicylic Acid
          • Sodium Phenolate (used for carbonylation)
            • Benzenesulfonic Acid (used for endothermic reaction)
        • Methanol
    • Acetyl Chloride
      • Acetic Anhydride
      • Hydrogen Chloride
      • (Hydrochloric Acid is made when hydrogen chlorine enters contact with water.)
    • Acetic Acid - used to make more acetic anhydride (methanol + acetic acid (+ sulfuric acid) = acetic anhydride)
  • Vicodillicaine - strong headache med, hallucinogen
  • Zepprocane - barbiturate, used as anxiolytic and anticonvulsant
    • Barbituric Acid - an acidic reagent, reacts with artifacts
      • Hydrogen Iodide - light molecule often used in pharmaceutics and barbituric acid reaction
      • Sodium amalgam - from an exothermic reaction causing an alloy made of mercury and sodium which happens
        naturally when they're pressed together. causes no damage (0.0001 x 15 dmg)
  • Cordivol - "α1- + β-selective" α1 antagonist, non-selective: β1 + β2 antagonist
    • Propylene glycol - used in foods
      • Propylene oxide - flammable
      • Aryloxypropanolamine - a precursor to most β-blockers
        • Catechol - from catechin, but not here though
          • Hydrogen Peroxide - oxidizing agent
        • Epichlorohydrin - synthesis-related molecule
          • Allyl Chloride - used to be an antiseptic
  • Naguuprofen - mild headache med, normally used to combat hangovers. isobutylphenylethanol is mixed with carbon and oxygen alongside hydrogen chlorine, with iron acting as a catalyst
    • Isobutylphenylethanol - from the former and hydrogen
      • Isobutylacetophenone - from a mix of the two former
        • Isobutylbenzene - from toluene and propene, with a sodium-potassium catalyst
        • Hydrogen Fluoride - hydrogen and fluorine with heat applied
          • Tuolene - a mix of benzene and methanol, using sulfuric acid as a catalyst
          • Propene - from acetone, charcoal, and some heat
Abandonned/Scrapped Dawcicadone - cholinesterase inhibitors and glutamate regulators? memory loss. Vanlicylicane - Mild leg pain painkiller. Grahatrocine - light painkiller for shoulder pain. Scotycoine - mild painkiller for stomach pain.

Media

https://github.com/user-attachments/assets/f99adbf1-8a04-418a-b5a3-3430ee373384
Things might have been modified or non-existent since the upload of the video above upon request from @KittenColony

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
🆑

  • add: 5 new pharmaceutical reagents to synthetize
  • add: 27 new reagents that either burns you chemically or will kill you if you dare to even lick it

@LankLTE
Copy link
Contributor

LankLTE commented Jan 22, 2025

Immediate look is that this should be in our namespace and not DV’s.

I’ll look at all the chemicals more closely later. I’m not sure if “as close as I can recreate the synthesis of pharmaceuticals in Space Station 14” is something we really want.. this is still a game after all, but that’s a discussion for later.

@Bribrooo
Copy link
Contributor Author

Immediate look is that this should be in our namespace and not DV’s.

I made that for Delta-V originally, and I'm still working on it (*saul telephone booth breakdown scene*) so I would appreciate it at least being in the namespace that it is supposed to go in.

I’ll look at all the chemicals more closely later. I’m not sure if “as close as I can recreate the synthesis of pharmaceuticals in Space Station 14” is something we really want.. this is still a game after all, but that’s a discussion for later.

Also, I can not really make other recipes for it. They are added with their recipes and steps of synthesis or they just don't come... (not to threaten you all... sorry...) You can understand my frustration for spending the last 7 months with a real pharmacist in an opposite timezone as me just for it to be reduced to adding sugar to water.
Also, keep in mind that those reagents were designed to be synthesized by a completely new map specific role: the Pharmacist (or called Psychiatrist, but it's not a psychiatrist I don't know why DV maintainer would call it that...)

@dffdff2423
Copy link
Collaborator

dffdff2423 commented Jan 22, 2025

Also not looked at it yet. Just going based on the PR description and what Lank said.

I made that for Delta-V originally, and I'm still working on it (saul telephone booth breakdown scene) so I would appreciate it at least being in the namespace that it is supposed to go in.

We want everything to be in our namespace so you do not have to look through multiple directories to find everything that is our content. I know that is not standard on other forks, however it has been something that has definitely been worth the extra effort in the long run. If you are porting stuff from DV you can export a patch from github by appending .patch to the end of the URL on github, change the pathnames using sed -i ... and apply it with git am. Alternatively, it may just be better to wait until the subsystem is fully complete.

Also, I can not really make other recipes for it. They are added with their recipes and steps of synthesis or they just don't come... (not to threaten you all... sorry...) You can understand my frustration for spending the last 7 months with a real pharmacist in an opposite timezone as me just for it to be reduced to adding sugar to water.
Also, keep in mind that those reagents were designed to be synthesized by a completely new map specific role: the Pharmacist (or called Psychiatrist, but it's not a psychiatrist I don't know why DV maintainer would call it that...)

I get it, but most people don't really enjoy organic chemistry IRL and when it is just reduced to the standard "mix stuff in container" it can get quite boring. I think it would be more interesting if the recipes had various interesting crafting systems (potentially based on how they are created IRL). It may also be better to use "common names" instead of the IUPAC ones (when they exist) as the average player will be able to relate to it more. However, I would prefer we do not use real medication names as that can sometimes be a bit "too close to home" for people (feel free to come up with fictional ones).

@Bribrooo
Copy link
Contributor Author

However, I would prefer we do not use real medication names as that can sometimes be a bit "too close to home" for people (feel free to come up with fictional ones).

The names of medications are fictional, all of them. The other reagents are not since we have already existing reagents made for recipes that have their real world name

@dffdff2423
Copy link
Collaborator

dffdff2423 commented Jan 24, 2025

We discussed this on discord a bit here. The general consensus was the following:

  • While it is very realistic, the additional reagents are too much additional clutter. We do not want to add ~15-20 new chems solely for the purpose of creating medication.
  • The length of recipe chains is fine if they primarily used existing chemicals in the game.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants