Rename time_taken to time_taken_ms#7649
Open
adezxc wants to merge 1 commit into
Open
Conversation
dosubot
Bot
added
component/query-frontend
go
adezxc
force-pushed
the
feat/rename_time_taken_field
branch
from
752c925 to
4df5cc0
Compare
Signed-off-by: Adam Jasinski <adam.jasinski@vinted.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Rename
time_takenfield totime_taken_msand make it output millisecond count, so sorting and filtering on the field could be done. This was also merged in the Thanos query-frontend part here: thanos-io/thanos#8831Let me know if I should instead add a new field without removing the old one.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]