Repository navigation
Consent: leave macOS permission cards of an ended session to Cingulate - #1407
Open
aft-alfonso[bot] wants to merge 2 commits into
Open
aft-alfonso[bot] wants to merge 2 commits into
aft-alfonso[bot] wants to merge 2 commits into
Conversation
AFT withdraws its macOS permission cards at startup under the scope each was filed in. When that session has ended the daemon refuses the route (scope_not_live / scope_ended), so every withdrawal failed and the row was kept for the next start, where it failed again. That refusal is now its own ConsentError::ScopeGone; startup drops the record and leaves the ask to Cingulate, which settles asks of ended scopes itself. A held call that meets it still gets the unavailable answer it got before. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At startup AFT withdraws the macOS permission cards it recorded, each under the scope it was filed in. When the filing session has ended, the daemon refuses the route (
scope_not_live), so on the 0.64 RC card all 38 withdrawals failed and their rows stayed for the next start, where they would fail again.That refusal now maps to a new
ConsentError::ScopeGone. Startup drops the record and leaves the ask to Cingulate, which settles asks of ended scopes itself (SUBC's change on the Cingulate side). A held tool call that meets the refusal gets the same unavailable answer as before, so no agent-visible text changes.Tests:
subc::consent::(192, macOS) including a newmacos_permission_startup_drops_cards_whose_scope_ended; Windows compile with warnings as errors.Summary by cubic
Fixes repeated startup failures for macOS permission cards whose filing scope has ended, leaving their settlement to Cingulate.
When the daemon refuses the withdrawal route with
scope_not_liveorscope_ended, AFT now maps the error to a newConsentError::ScopeGoneand drops the card record instead of keeping it for another retry at the next start. Held tool calls that meet this refusal still get the same unavailable answer as before, so no agent-visible text changes.Written for commit d97abc1. Summary will update on new commits.