Repository navigation
stage-card: write the card's sidecar under the name the placer checks - #1406
Merged
Merged
Conversation
The placer verifies `<card>.sha256`; stage-card wrote only `<card>.sha256.postsign`, so every staged card needed the sidecar copied by hand before placement. It now writes `<card>.sha256` and keeps the .postsign copy. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daemon placer verifies
<card>.sha256beside a staged card;scripts/stage-card.shwrote only<card>.sha256.postsign, so SUBC had to ask for the sidecar before placing the 0.64 RC card. The script now writes<card>.sha256(checked withshasum -c) and keeps the.postsigncopy for anything that reads that name. Script syntax andscripts/lib/test_workflow_gates.py(65 tests) pass.Summary by cubic
Fixes
scripts/stage-card.shso the sidecar is written as<card>.sha256, the name the daemon placer verifies, instead of only<card>.sha256.postsign. Adds a benchmark descriptor for this branch atbenchmarks/aft-search/slice-descriptors/land-stage-card-sidecar.json.Staged cards no longer need the sidecar copied by hand before placement; the
.postsigncopy is still written forrelease.shanddev-rebuild.sh.Written for commit 68df918. Summary will update on new commits.