Code

Lower Bounds Inference#718

Code

Merged

john-h-kastner merged 118 commits intomaincorrectcomputation/checkedc-clang:mainfrom

range_boundscorrectcomputation/checkedc-clang:range_boundsCopy head branch name to clipboard

Dec 2, 2021

Commits

Commits on Oct 6, 2021

• Initial implementation of range bounds

  john-h-kastner

  committed
  93802d7

  Copy full SHA for 93802d7

• Add tests

  john-h-kastner

  committed
  c6c3d79

  Copy full SHA for c6c3d79

• Update testgenerator.py to handle new bounds

  john-h-kastner

  committed
  eeddaca

  Copy full SHA for eeddaca

• Update generated tests

  john-h-kastner

  committed
  78eacbb

  Copy full SHA for 78eacbb

• Update assigment expression containing pointers with range bounds

  john-h-kastner

  committed
  a6f6b4b

  Copy full SHA for a6f6b4b

• Update generated test

  john-h-kastner

  committed
  a41cc25

  Copy full SHA for a41cc25

• add test

  john-h-kastner

  committed
  22f2159

  Copy full SHA for 22f2159

• Use same logic to check for pointer arithmetic in an assignment in array bounds inference and rewriter.

  john-h-kastner

  committed
  a9cb21f

  Copy full SHA for a9cb21f

• Cleanup and reduce duplicate code

  john-h-kastner

  committed
  fad5d29

  Copy full SHA for fad5d29

• Don't add range bounds for fields or global variables

  john-h-kastner

  committed
  0de3945

  Copy full SHA for 0de3945

• Cleanup

  john-h-kastner

  committed
  a1b84aa

  Copy full SHA for a1b84aa

• Add `insertText` function to insert text with same checks as rewriteSourceRange.

  john-h-kastner

  committed
  e474df6

  Copy full SHA for e474df6

• Add another test case

  john-h-kastner

  committed
  a4d2f9b

  Copy full SHA for a4d2f9b

Commits on Oct 8, 2021

• Fix error in range bounds for byte count

  john-h-kastner

  committed
  53ffbc4

  Copy full SHA for 53ffbc4

Commits on Oct 13, 2021

• Avoid rewrite error when an update of a pointer with range bounds is in

  Show description for 821270c
  john-h-kastner

  committed
  821270c

  Copy full SHA for 821270c

Commits on Oct 15, 2021

• Add tests and tidy code

  john-h-kastner

  committed
  550f773

  Copy full SHA for 550f773

• Move some reference parameters into returned structure.

  john-h-kastner

  committed
  ecccac0

  Copy full SHA for ecccac0

• Comments

  john-h-kastner

  committed
  de7bb97

  Copy full SHA for de7bb97

• Test byte count range bounds

  john-h-kastner

  committed
  f233422

  Copy full SHA for f233422

• Fix order of new declarations in multi-decls

  john-h-kastner

  committed
  9a02e56

  Copy full SHA for 9a02e56

Commits on Oct 18, 2021

• Merge remote-tracking branch 'origin/main' into range_bounds

  john-h-kastner

  committed
  17b9fc1

  Copy full SHA for 17b9fc1

• Tidying and comments

  john-h-kastner

  committed
  3557eb9

  Copy full SHA for 3557eb9

• Also don't add range bounds on constant size arrays

  john-h-kastner

  committed
  a440e50

  Copy full SHA for a440e50

• More cleanup

  john-h-kastner

  committed
  d0e718e

  Copy full SHA for d0e718e

Commits on Oct 19, 2021

• Merge remote-tracking branch 'origin/main' into range_bounds

  john-h-kastner

  committed
  79d8121

  Copy full SHA for 79d8121

Commits on Oct 25, 2021

• Merge remote-tracking branch 'origin/main' into range_bounds

  john-h-kastner

  committed
  d842773

  Copy full SHA for d842773

Commits on Oct 26, 2021

• Small test update

  john-h-kastner

  committed
  cd60b76

  Copy full SHA for cd60b76

• comment fix

  john-h-kastner

  committed
  023e282

  Copy full SHA for 023e282

Commits on Oct 27, 2021

• Abounds.cpp cleanup

  john-h-kastner

  committed
  241e9d5

  Copy full SHA for 241e9d5

Commits on Oct 28, 2021

• Add test case for count-plus-one bounds

  john-h-kastner

  committed
  c24b5d0

  Copy full SHA for c24b5d0

Commits on Oct 29, 2021

• ScopeVisitor cleanup

  john-h-kastner

  committed
  cc3ae93

  Copy full SHA for cc3ae93

• wip

  john-h-kastner

  committed
  371b9a1

  Copy full SHA for 371b9a1

Commits on Nov 1, 2021

• wip

  john-h-kastner

  committed
  778741b

  Copy full SHA for 778741b

• Add a new field to ABounds

  john-h-kastner

  committed
  703f6e1

  Copy full SHA for 703f6e1

Commits on Nov 8, 2021

• wip

  john-h-kastner

  committed
  de8eb79

  Copy full SHA for de8eb79

• wip

  john-h-kastner

  committed
  aedd269

  Copy full SHA for aedd269

• wip

  john-h-kastner

  committed
  f8886ad

  Copy full SHA for f8886ad

• Improved method for find invalidated base pointers

  john-h-kastner

  committed
  11ae7ae

  Copy full SHA for 11ae7ae

Commits on Nov 9, 2021

• Cleanup

  john-h-kastner

  committed
  b4ada01

  Copy full SHA for b4ada01

• Initial propagation of temp lower bound

  john-h-kastner

  committed
  8cdfeb4

  Copy full SHA for 8cdfeb4

• Finish propagating temp lower bounds

  john-h-kastner

  committed
  98a99ae

  Copy full SHA for 98a99ae

Commits on Nov 10, 2021

• Don't add extra fresh lower bounds

  john-h-kastner

  committed
  d8641dc

  Copy full SHA for d8641dc

• Cleanup old code

  john-h-kastner

  committed
  de80ab6

  Copy full SHA for de80ab6

Commits on Nov 11, 2021

• WIP: Fix regression tests

  john-h-kastner

  committed
  878a865

  Copy full SHA for 878a865

• WIP

  john-h-kastner

  committed
  f0e11e3

  Copy full SHA for f0e11e3

• WIP

  john-h-kastner

  committed
  d14fedc

  Copy full SHA for d14fedc

Commits on Nov 12, 2021

• fixes

  john-h-kastner

  committed
  7b57c83

  Copy full SHA for 7b57c83

• Fix bug in context sensitive assignment

  john-h-kastner

  committed
  c82a93d

  Copy full SHA for c82a93d

• Avoid referencing undefined parameter names

  john-h-kastner

  committed
  09187d4

  Copy full SHA for 09187d4

• update test

  john-h-kastner

  committed
  2931014

  Copy full SHA for 2931014

• Update generated tests

  john-h-kastner

  committed
  b5d09c1

  Copy full SHA for b5d09c1

• Fix bug

  john-h-kastner

  committed
  2ec3486

  Copy full SHA for 2ec3486

• remove debug prints

  john-h-kastner

  committed
  a4c671f

  Copy full SHA for a4c671f

• Don't propagate lower bounds over context sensitive edges

  john-h-kastner

  committed
  ee97b36

  Copy full SHA for ee97b36

• Add tests for new inference

  john-h-kastner

  committed
  d1829ba

  Copy full SHA for d1829ba

Commits on Nov 15, 2021

• Hopefully better handling of conflicting lower bounds

  john-h-kastner

  committed
  623dbbd

  Copy full SHA for 623dbbd

Commits on Nov 16, 2021

• fix condition

  john-h-kastner

  committed
  c9a7a54

  Copy full SHA for c9a7a54

• Add missing null checks

  john-h-kastner

  committed
  6bd858d

  Copy full SHA for 6bd858d

Commits on Nov 17, 2021

• Improve rewriting with lower bound generation and function redeclaration

  john-h-kastner

  committed
  bbc60f1

  Copy full SHA for bbc60f1

• Use name from generated lower bound ProgramVar

  john-h-kastner

  committed
  0b05be7

  Copy full SHA for 0b05be7

• Rewrite inference algorithm

  john-h-kastner

  committed
  cfec386

  Copy full SHA for cfec386

Commits on Nov 18, 2021

• Use sets for lower bound

  john-h-kastner

  committed
  17314a4

  Copy full SHA for 17314a4

Commits on Nov 19, 2021

• Fix for existing bounds

  john-h-kastner

  committed
  c7f02fa

  Copy full SHA for c7f02fa

• Add a test case

  john-h-kastner

  committed
  bf92e18

  Copy full SHA for bf92e18

• Revert "Use sets for lower bound"

  Show description for 6d4636f
  john-h-kastner

  committed
  6d4636f

  Copy full SHA for 6d4636f

• wip

  john-h-kastner

  committed
  e587082

  Copy full SHA for e587082

Commits on Nov 22, 2021

• Fix potential infinte loop.

  Show description for d0a0984
  john-h-kastner

  committed
  d0a0984

  Copy full SHA for d0a0984

• Fix for malloc not invalidating lower bound

  john-h-kastner

  committed
  50ec3d1

  Copy full SHA for 50ec3d1

Commits on Nov 23, 2021

• Merge remote-tracking branch 'origin/main' into infer_lower_bound

  john-h-kastner

  committed
  da2b45e

  Copy full SHA for da2b45e

• Don't invalidate function paramter lower bound based on arguments

  john-h-kastner

  committed
  1290806

  Copy full SHA for 1290806

• Add more test cases

  john-h-kastner

  committed
  bd2ba95

  Copy full SHA for bd2ba95

• Shome comments and cleanup

  john-h-kastner

  committed
  fd7f2f2

  Copy full SHA for fd7f2f2

• Tidy code

  john-h-kastner

  committed
  4993902

  Copy full SHA for 4993902

Commits on Nov 24, 2021

• Merge branch 'infer_lower_bound' into range_bounds

  john-h-kastner

  committed
  0f7ddfc

  Copy full SHA for 0f7ddfc

• More code cleanup

  john-h-kastner

  committed
  8213cf9

  Copy full SHA for 8213cf9

• Make some methods private

  john-h-kastner

  committed
  728f1b1

  Copy full SHA for 728f1b1

• Remove semicolon

  john-h-kastner

  committed
  bf55a40

  Copy full SHA for bf55a40

• Cleanup unnecessary change

  john-h-kastner

  committed
  5dd0882

  Copy full SHA for 5dd0882

• More cleanup

  john-h-kastner

  committed
  d7581c8

  Copy full SHA for d7581c8

• Change warning to assert

  john-h-kastner

  committed
  abdb844

  Copy full SHA for abdb844

• comments

  john-h-kastner

  committed
  bb04cde

  Copy full SHA for bb04cde

• Comments

  john-h-kastner

  committed
  533e1ca

  Copy full SHA for 533e1ca

• Rename "BasePointer" -> "LowerBound"

  john-h-kastner

  committed
  aab187c

  Copy full SHA for aab187c

• Cmakelist

  john-h-kastner

  committed
  d7b3ade

  Copy full SHA for d7b3ade

• Work around Rewriter::ReplaceText bug with a previous insertion.

  mattmccutchen-cci

  committed
  739bebc

  Copy full SHA for 739bebc

• Revert change to PrevEnd computation in DeclRewriter::rewriteMultiDecl.

  Show description for 9dbcca8
  mattmccutchen-cci

  committed
  9dbcca8

  Copy full SHA for 9dbcca8

Commits on Nov 30, 2021

• Change mkStringForDeclWithUnchangedType back to return a string.

  mattmccutchen-cci

  committed
  2e42f3e

  Copy full SHA for 2e42f3e

Commits on Dec 1, 2021

• Use getNextComma to insert supplementary declarations in a multi-decl.

  Show description for 48fad85
  mattmccutchen-cci

  committed
  48fad85

  Copy full SHA for 48fad85

• Update clang/include/clang/3C/RewriteUtils.h

  Show description for 4bd4263
  

  john-h-kastner

  and

  mattmccutchen-cci

  authored
  4bd4263

  Copy full SHA for 4bd4263

• Update clang/include/clang/3C/LowerBoundAssignment.h

  Show description for ed7e41d
  

  john-h-kastner

  and

  mattmccutchen-cci

  authored
  ed7e41d

  Copy full SHA for ed7e41d

• Update clang/lib/3C/ConstraintBuilder.cpp

  Show description for 815ef0e
  

  john-h-kastner

  and

  mattmccutchen-cci

  authored
  815ef0e

  Copy full SHA for 815ef0e

• Update clang/test/3C/range_bounds.c

  Show description for cd51b81
  

  john-h-kastner

  and

  mattmccutchen-cci

  authored
  cd51b81

  Copy full SHA for cd51b81

• Update clang/lib/3C/ConstraintBuilder.cpp

  Show description for fefd429
  

  john-h-kastner

  and

  mattmccutchen-cci

  authored
  fefd429

  Copy full SHA for fefd429

• Update clang/include/clang/3C/LowerBoundAssignment.h

  Show description for b3b5a74
  

  john-h-kastner

  and

  mattmccutchen-cci

  authored
  b3b5a74

  Copy full SHA for b3b5a74

• Update clang/test/3C/range_bounds.c

  Show description for edec320
  

  john-h-kastner

  and

  mattmccutchen-cci

  authored
  edec320

  Copy full SHA for edec320

• Update clang/test/3C/range_bounds.c

  Show description for dc27d9b
  

  john-h-kastner

  and

  mattmccutchen-cci

  authored
  dc27d9b

  Copy full SHA for dc27d9b

• Update clang/test/3C/range_bounds.c

  Show description for 0d69fc4
  

  john-h-kastner

  and

  mattmccutchen-cci

  authored
  0d69fc4

  Copy full SHA for 0d69fc4

• -itypes-for-extern should not force supplementary decls to be unchecked.

  Show description for c8b2532
  mattmccutchen-cci

  committed
  c8b2532

  Copy full SHA for c8b2532

• Update testgenerator comments

  john-h-kastner

  committed
  ce27524

  Copy full SHA for ce27524

• Add realloc to allocator heuristics

  john-h-kastner

  committed
  77905e6

  Copy full SHA for 77905e6

• Rename function

  john-h-kastner

  committed
  c28ee43

  Copy full SHA for c28ee43

• Merge remote-tracking branch 'origin/range_bounds.msfdwut_refactor' into range_bounds

  john-h-kastner

  committed
  7a2cfe4

  Copy full SHA for 7a2cfe4

• Merge remote-tracking branch 'origin/range_bounds.itypes_for_extern' into range_bounds

  john-h-kastner

  committed
  1013f61

  Copy full SHA for 1013f61

• Comment tweak

  john-h-kastner

  committed
  2aee4ef

  Copy full SHA for 2aee4ef

• Add -itypes-for-extern test

  john-h-kastner

  committed
  70c0443

  Copy full SHA for 70c0443

• Remove FIXME

  john-h-kastner

  committed
  4e245cb

  Copy full SHA for 4e245cb

• Expand on TODO comment

  john-h-kastner

  committed
  bc780d3

  Copy full SHA for bc780d3

• Update field comments

  john-h-kastner

  committed
  b3907ed

  Copy full SHA for b3907ed

• More comment tweaks

  john-h-kastner

  committed
  91a19a6

  Copy full SHA for 91a19a6

• Merge remote-tracking branch 'origin/range_bounds.matt_rewrite_offset' into range_bounds

  john-h-kastner

  committed
  33ccff0

  Copy full SHA for 33ccff0

• Rename __3c_tmp -> __3c_lower_bound

  john-h-kastner

  committed
  17a6145

  Copy full SHA for 17a6145

• Merge remote-tracking branch 'origin/range_bounds.getnextcomma' into range_bounds

  john-h-kastner

  committed
  cf4c849

  Copy full SHA for cf4c849

• Revert hack in testgenerator.py no longer required now that extra new

  Show description for 03f3685
  john-h-kastner

  committed
  03f3685

  Copy full SHA for 03f3685

• Add another test case

  john-h-kastner

  committed
  702e658

  Copy full SHA for 702e658

• Reword some comments to talk about fresh lower bounds rather than range bounds

  Show description for 81f9b6f
  john-h-kastner

  committed
  81f9b6f

  Copy full SHA for 81f9b6f

• Some comments and minor code tweaks

  john-h-kastner

  committed
  7fc73b2

  Copy full SHA for 7fc73b2

Commits on Dec 2, 2021

• Work around issue encounted in vsftpd port phase two

  Show description for 6584d3c
  john-h-kastner

  committed
  6584d3c

  Copy full SHA for 6584d3c

• Tidy

  john-h-kastner

  committed
  8f4c58b

  Copy full SHA for 8f4c58b