Skip to content

Add support for -Xclang -ast-dump to facilitate debugging. #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

mattmccutchen-cci
Copy link
Member

Add documentation for the feature, but first, split out a "developer guide" from CONTRIBUTING.md to have a good place to put the documentation and make some other minor revisions.


I ran into a case where I wanted this feature on a branch other than #657, so I think it's time to submit a PR to main. I'm tentatively requesting review from Kyle since he's familiar with some of this code from #598, but if someone else is interested and gets to it first, great. Note that git diff --color-moved may be helpful to verify the text moved verbatim between CONTRIBUTING.md and development.md.

Add documentation for the feature, but first, split out a "developer
guide" from CONTRIBUTING.md to have a good place to put the
documentation and make some other minor revisions.
Copy link
Member

@kyleheadley kyleheadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the extra comments, as the interface to the Diagnostic verifier is complex and poorly documented on their side.

Copy link
Collaborator

@aaronjeline aaronjeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Comments on the addition are great.

@mattmccutchen-cci mattmccutchen-cci merged commit 50e0a25 into main Sep 13, 2021
@mattmccutchen-cci
Copy link
Member Author

Whoops, I merged main into the PR branch locally and ran the regression tests, but I forgot to push that merge to GitHub before merging the PR. Sorry. In any case, the code I tested is identical to main following the PR merge.

@mattmccutchen-cci mattmccutchen-cci deleted the ast-dump branch September 13, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants