Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-Enroll Release CP Fixes #955

Merged
merged 5 commits into from
Oct 30, 2024
Merged

Pre-Enroll Release CP Fixes #955

merged 5 commits into from
Oct 30, 2024

Conversation

nidhi-mylavarapu
Copy link
Contributor

Summary

  • added new majors + changed major schools
  • added abbreviations

Test Plan

  • nutritional sciences major shows up under CALS and HE, abbreviations next to schools

@nidhi-mylavarapu nidhi-mylavarapu requested a review from a team as a code owner October 30, 2024 21:15
@dti-github-bot
Copy link
Member

dti-github-bot commented Oct 30, 2024 •
edited
Loading

[diff-counting] Significant lines: 24.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 3492bfa):

https://cornelldti-courseplan-dev--pr955-nidhi-pre-enroll-rel-d79sydbf.web.app

(expires Fri, 29 Nov 2024 21:31:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933

plumshum
plumshum approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@plumshum plumshum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM hurray for adding it to humanec! :D

@nidhi-mylavarapu nidhi-mylavarapu merged commit d88148c into main Oct 30, 2024
11 checks passed
@nidhi-mylavarapu nidhi-mylavarapu deleted the nidhi/pre-enroll-release-fixes branch October 30, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plumshum plumshum plumshum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nidhi-mylavarapu @dti-github-bot @plumshum