saved courses into main #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change course menu to click state (#898) * add save button and icon * change position of save course button * added new Save Course Modal * added new Save Course Modal * added basic front-end look * re-edit teleport modal * fixed basic front-end look * renamed icon * fixed frontend alignment * fixed frontend alignment and file path * added feature flag for save course modal * fixed front-end bug and modal hierachy * change method and emit names --------- Co-authored-by: KaylinChan <[email protected]>
- can save a course when press 'done' - course is saved to an empty collection - add functions for add & edit collection
- can save one course to multiple collections w/ checkbox - saved course will be removed from semester view and from fullfilled requirements - pop up notification
- finished scrollable checkbox frontend - fixed the bug for selecting a singular checkbox - believed its stored in firestore when added to collection - renamed collection to savedCourses for firesetore clarity
- saveCourseModal allow user to name their new collections - moved scss into a separate file
- added updateDoc in backend functions - made edit Collections modal more functional with saveCourse
* add icon * fix icon * feature flag * fixed feature flags * collections page empty front-end look (#940) * added save-collection emit * create sidebar vue * connected dashboard and sidebar * finished empty front-end look * adjust hover * fixed positioning * update artifact version * added front-end look for saved courses in collection * fixed collectionsidebar css for frontend implementation * edit collection modal + front-end fixes - added edit collection modal and text input collection modal - fixed front-end with trash can - fixed front-end with dropdown button and edit collection button * frontend fixes - fixed padding - fixed null issue * added helper function in utilities * ran prettier * frontend fixes --------- Co-authored-by: Hannah Zhou <[email protected]> Co-authored-by: Hannah Zhou <[email protected]>
Simon draggable saved courses
…rse-plan into hannah--merge-collection
merge collection frontend and backend
|
[diff-counting] Significant lines: 1444. This diff might be too big! Developer leads are invited to review the code. |
|
Visit the preview URL for this PR (updated for commit 8b9bbb2): https://cornelldti-courseplan-dev--pr954-saved-courses-jnes7zzy.web.app (expires Fri, 29 Nov 2024 22:47:00 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933 |
nidhi-mylavarapu
approved these changes
Oct 30, 2024
nidhi-mylavarapu
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is the finalizing saved courses for main and then release
- [ ] finalize padding and color
Remaining TODOs:
Depends on #{number of PR}
Test Plan
Notes
Blockers
Breaking Changes