Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dynamic UI to Home Page to Fix Overflows #235

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Conversation

3TTemi
Copy link
Contributor

@3TTemi 3TTemi commented Nov 17, 2024

Summary

This pull request works towards addressing continuous overflow errors that made UI for bigger and smaller phones to have overflow, specifically on the home screen (main area of concern).

  • Main changes included added Media Queries rather than using fixed values

Test Plan

  • Tested on Iphone 11, Iphone 15 pro, Pixel 7 Pro, and Pixel 3 simulators with working desing

  • Can continued to be tested on other devices as well and on actual devices

Notes

  • Android SDK Version was also updated so it could be simulated on android
  • Some specific changes were made to custom to IOS vs Android devices because solutions with Safe Area and View Padding were not working

Sorry, something went wrong.

@dti-github-bot
Copy link
Member

dti-github-bot commented Nov 17, 2024

[diff-counting] Significant lines: 154.

@Jcheng777
Copy link

Nice job adding custom paddings for different platforms! It could be worthwhile to consider encapsulating the platform-specific padding logic into a separate method for reusability!

BrianLa0616
BrianLa0616 previously approved these changes Nov 18, 2024
Copy link
Contributor

@BrianLa0616 BrianLa0616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

I think you also fixed the futures issue that was creating a lot of errors.

Copy link
Contributor

@BrianLa0616 BrianLa0616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed comments

@3TTemi 3TTemi merged commit 60f676e into master Nov 18, 2024
12 checks passed
@3TTemi 3TTemi deleted the ta375/dynamic-ui branch November 18, 2024 22:05
shah-esha pushed a commit that referenced this pull request Dec 4, 2024
* Fix Future Async conflict casuing app freeze

* Transition to MediaQuery for home page and challenge cells

* Implemented custom padding adjustments for Iphone and Android

* Add documentation for navigation between home, search bar/filtering, and challenges

* Add constant device varibales instead of MediaQuery Calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants