-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dynamic UI to Home Page to Fix Overflows #235
Conversation
…and challenges
[diff-counting] Significant lines: 154. |
Nice job adding custom paddings for different platforms! It could be worthwhile to consider encapsulating the platform-specific padding logic into a separate method for reusability! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
I think you also fixed the futures issue that was creating a lot of errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed comments
* Fix Future Async conflict casuing app freeze * Transition to MediaQuery for home page and challenge cells * Implemented custom padding adjustments for Iphone and Android * Add documentation for navigation between home, search bar/filtering, and challenges * Add constant device varibales instead of MediaQuery Calls
Summary
This pull request works towards addressing continuous overflow errors that made UI for bigger and smaller phones to have overflow, specifically on the home screen (main area of concern).
Test Plan
Tested on Iphone 11, Iphone 15 pro, Pixel 7 Pro, and Pixel 3 simulators with working desing
Can continued to be tested on other devices as well and on actual devices
Notes