Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ranking List Names Updated with Ellipsis #224

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Conversation

3TTemi
Copy link
Contributor

@3TTemi 3TTemi commented Sep 22, 2024

Summary

Fixes one of the low priority bugs of overflowing with long useranems

Remaining TODOs:

  • Create system to reduce points text in leaderboard (Ex: 15,000 -> 15k)

Test Plan

Can be seen in on the global leaderboard page with any longer test names or current names in the backend

@dti-github-bot
Copy link
Member

dti-github-bot commented Sep 22, 2024

[diff-counting] Significant lines: 12.

Copy link
Contributor

@BrianLa0616 BrianLa0616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use built in Text handler

Copy link
Collaborator

@Shengle-Dai Shengle-Dai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good overall, but as Brian mentioned, maybe there are more concise built-in methods to achieve the truncation!

Copy link
Contributor

@BrianLa0616 BrianLa0616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed comments! Good job!

@3TTemi 3TTemi merged commit 7f36332 into master Nov 18, 2024
10 checks passed
@3TTemi 3TTemi deleted the ta375/leaderboard-ui-fixes branch November 18, 2024 22:05
shah-esha pushed a commit that referenced this pull request Dec 4, 2024
* Ranking List Names Updated with Ellipsis

* truncate with flutter ellipsis

* Removed Custom Function repalced with flutter ellipsis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants