-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ranking List Names Updated with Ellipsis #224
Conversation
[diff-counting] Significant lines: 12. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use built in Text handler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good overall, but as Brian mentioned, maybe there are more concise built-in methods to achieve the truncation!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed comments! Good job!
* Ranking List Names Updated with Ellipsis * truncate with flutter ellipsis * Removed Custom Function repalced with flutter ellipsis
Summary
Fixes one of the low priority bugs of overflowing with long useranems
Remaining TODOs:
Test Plan
Can be seen in on the global leaderboard page with any longer test names or current names in the backend