-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update flutter data model + new admin features #214
Conversation
[diff-counting] Significant lines: 1383. This diff might be too big! Developer leads are invited to review the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved all issues (talked through in person and on Slack). Achievements are fully working, so are real time event updates on the flutter side.
Only thing that doesn't work yet is updating event trackers upon adding a new challenge to an existing completed event. This isn't really necessary for internal launch though and the other changes in this PR need to be merged in asap. We can continue working on this feature in a later PR.
The achievement tracking functions and logic for completeChallenge LGTM! I just finished some e2e tests for achievement tracker and tested -- they all run successfully. I added the tests to a new PR! |
* implement achievements tracking logic * Fix achievement service import * Add cascading delete to achievement tracker * implement event lists from org * Made achievement admin frontend * Bug fixes * fixed bugs, still need to pass tests * Fix event trackers * Fix flutter build * Finish achievement tracking * Fix emit order * Fix other emit error * Fix build errors * Connected achievements to backend * Fix inconsistencies * Complete integration * Remove hardcoded complete * Comment failing tests * Attempt to fix tests * Fix more e2e failures * Add exception for e2e tests in client service * Added extra logging * Fix incorrect nextChallenge * Fix tests * Fix nulls in test * Set progress limit * Add manager rule for achievements * Achivement trackers are made for all * Clarified prisma query * Fix underflow error + journeys --------- Co-authored-by: Jasmine Li <[email protected]>
Summary
This pull request updates the flutter data model to retrieve the latest changes from the server. Achievements are now editable form the admin frontend. We also have some useful new features like duplication and moving on admin frontend.
Test Plan
All journeys load as usual.