Splash and Registration UI #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 675. |
neketka
requested changes
Apr 14, 2024
There was a problem hiding this comment.
After testing the app I see a couple issues. Logout button sends you back to the registration screen but the backswipe gesture nullifies that. After closing and opening the app, it doesn't seem to attempt to relog into the app. Also, clicking back on the settings page doesn't do anything. If these changes are addressed, it should be good to go.
shah-esha
pushed a commit
that referenced
this pull request
Dec 4, 2024
* finished besides interests page * finished interests page * skip registration if relog * fix flutter build error * removed dart.ffi import * skip registration for guest, added guest as enrollment type * implemented log out in settings * set guest username in backend based on total num users * Changed logout toast * server build and format fix * fixed guest login bugs * fixed server format * fixed page navigation upon login and logout * LOL * Fix user tests * Fixed failing user tests --------- Co-authored-by: Cathryn Li <[email protected]> Co-authored-by: Brian La <[email protected]> Co-authored-by: neketka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request implements changes to the Splash Page and Registration flow based on the redesigns on Figma.
Remaining TODOs:
Test Plan
Test authorization using Android emulator (both Cornell login and guest login)
Notes
Blockers
Breaking Changes