Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jxl9/challenges journeys #162

Merged
merged 17 commits into from
Mar 7, 2024
Merged

Jxl9/challenges journeys #162

merged 17 commits into from
Mar 7, 2024

Conversation

jasmineee-li
Copy link
Contributor

@jasmineee-li jasmineee-li commented Mar 4, 2024

Edited UI for challenges & journeys

This pull request updates the UI for journeys and challenges pages in accordance with the newly handed off designs

Remaining TODOs:

  • connect challenges & journeys to backend

Copy link
Contributor

@nit0107 nit0107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, looks consistent with the hi-fi designs that were handed off!

@cathli66
Copy link
Contributor

cathli66 commented Mar 5, 2024

@nit0107, I saw you tested this branch too! Did you happen to test on an iOS device? I saw that a lot of iOS dependencies got updated during Jasmine's PR so wanted to make sure everything still runs fine on that end.

@cathli66
Copy link
Contributor

cathli66 commented Mar 5, 2024

Don't forget to update the pop up UI element after you press on a challenge/journey to the new designs on Figma also!

@dti-github-bot
Copy link
Member

dti-github-bot commented Mar 7, 2024

[diff-counting] Significant lines: 789.

Copy link
Contributor

@cathli66 cathli66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is good on my end now! Thanks for addressing all the comments/reviews :)

@jasmineee-li jasmineee-li merged commit 03b7eae into master Mar 7, 2024
10 checks passed
@jasmineee-li jasmineee-li deleted the jxl9/challenges-journeys branch March 7, 2024 22:44
shah-esha pushed a commit that referenced this pull request Dec 4, 2024
* edited challenges based on current homepage design

* made edits to challenges page

* made preliminary edits to journeys page based on new design

* edited challenge cell

* edited journey cell

* cleaned up code

* Added documentation to challenge_cell_new, challenge_cell, challenges_page, journeys_page

* Deleted deprecated files in Challenge

* Updated Preview UI for challenges & journeys

* Edited challenges page UI, updated references to deleted deprecated files

* Edited UI for challenge cell, journey cell, journeys page

* Deleted reference to deprecated file

* Fixed backend build issues

* Formatted flutter code

* fixed navigation and added in cgo logo

---------

Co-authored-by: cathli66 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants