-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jxl9/challenges journeys #162
Conversation
…_page, journeys_page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, looks consistent with the hi-fi designs that were handed off!
@nit0107, I saw you tested this branch too! Did you happen to test on an iOS device? I saw that a lot of iOS dependencies got updated during Jasmine's PR so wanted to make sure everything still runs fine on that end. |
Don't forget to update the pop up UI element after you press on a challenge/journey to the new designs on Figma also! |
…thub.com:cornell-dti/cornell-go into jxl9/challenges-journeys
[diff-counting] Significant lines: 789. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is good on my end now! Thanks for addressing all the comments/reviews :)
* edited challenges based on current homepage design * made edits to challenges page * made preliminary edits to journeys page based on new design * edited challenge cell * edited journey cell * cleaned up code * Added documentation to challenge_cell_new, challenge_cell, challenges_page, journeys_page * Deleted deprecated files in Challenge * Updated Preview UI for challenges & journeys * Edited challenges page UI, updated references to deleted deprecated files * Edited UI for challenge cell, journey cell, journeys page * Deleted reference to deprecated file * Fixed backend build issues * Formatted flutter code * fixed navigation and added in cgo logo --------- Co-authored-by: cathli66 <[email protected]>
Edited UI for challenges & journeys
This pull request updates the UI for journeys and challenges pages in accordance with the newly handed off designs
Remaining TODOs: