Repository navigation
ci: run the os matrix only in coreui/coreui-angular - #282
Merged
Merged
Conversation
runs-on was pinned to ubuntu-latest, so the windows and macOS entries of the matrix were duplicate Ubuntu jobs. Use matrix.os, and let the os list depend on the repository: coreui/coreui-angular runs all three systems, any other repository (the private pro repo that merges this file, forks) runs ubuntu only, so the workflow files stay identical and a sync does not conflict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runs-on was pinned to ubuntu-latest, so the windows and macOS entries of the matrix were three identical Ubuntu jobs per workflow. The jobs now run on matrix.os. The os list depends on the repository: coreui/coreui-angular runs ubuntu, windows and macOS, any other repository (the private pro repo that merges this file, forks) runs ubuntu only, so the workflow files stay identical between free and pro and a sync does not conflict. These checks have never run on windows or macOS before, so the run on this PR is the first measurement.