Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlay.d/40grub: remove 70_coreos-user.cfg #3399

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

champtar
Copy link
Contributor

bootupd sources user.cfg since before it allows configs.d coreos/bootupd@1475f25

bootupd sources user.cfg since before it allows configs.d
coreos/bootupd@1475f25
Copy link
Member

@HuijingHei HuijingHei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cgwalters
Copy link
Member

Thanks so much for all the work on this!!

I guess the main thing that could probably use some human validation is that the instructions for setting a GRUB password still work. But AFAICS your analysis is correct.

@cgwalters cgwalters merged commit f9a2278 into coreos:testing-devel Mar 18, 2025
3 checks passed
@HuijingHei
Copy link
Member

Verify GRUB password works with latest fcos that includes this patch (without source $prefix/70_coreos-user.cfg in the grub.cfg)

@champtar champtar deleted the rm-grub-user.cfg branch March 19, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants