Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] Rework prune #893

Closed
wants to merge 2 commits into from
Closed

[4.3] Rework prune #893

wants to merge 2 commits into from

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Nov 5, 2019

Cherrypick of #839 on 4.3

* Split "insert_build" helper out of cmd-prune
* Rework cmd-prune in python
* Add prune tests
This subcommand cleans up unreferenced builds on remote location. 
Currently only s3 buckets are implemented
@vrutkovs vrutkovs requested review from cgwalters, jlebon and ashcrow and removed request for cgwalters November 5, 2019 13:59
@cgwalters
Copy link
Member

But this means we've now actually forked for 4.3...I'm going to aim to get RHCOS working with cosa master again today, then we can just fast forward to latest cosa master?

Let's really really try hard not to get into the fork situation again?

@vrutkovs
Copy link
Member Author

vrutkovs commented Nov 5, 2019

Oh, I thought branching is a standard process, not something we want to avoid

@ashcrow ashcrow requested review from arithx and removed request for ashcrow November 5, 2019 15:06
@arithx
Copy link
Contributor

arithx commented Nov 5, 2019

Should this be targeting the rhcos-4.3 branch instead of master?

@cgwalters
Copy link
Member

Oh, I thought branching is a standard process, not something we want to avoid

Per discussion on private chat, I think we definitely want tags (i.e. regular releases) - that's just a good idea. But branching can quickly become forking which is very problematic for everyone who needs to work on both OSes.

For 4.2, we did need to branch because 4.2 RHCOS needed Anaconda, but 4.3 dropped that.

Currently, the rhcos-4.3 branch is just effectively a tag.

What unifiying is blocking on is coreos/ignition-dracut#132

@vrutkovs
Copy link
Member Author

vrutkovs commented Nov 5, 2019

Agreed, tags seem to be a better idea. Closing this to avoid confusion

@vrutkovs vrutkovs closed this Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants