cmd-koji-upload: Add support for node-image #4081
Merged
+97
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of hardcoded path - This change makes the parent directory configurable by using the `buildroot` value passed in `kwargs`, improving flexibility and compatibility with different build environments. Signed-off-by: Renata Ravanelli <[email protected]>
- Refactored the code to centralize variable definitions and method calls into the Build class __init__ method. This improves readability and avoids scattered variable access throughout the logic. Signed-off-by: Renata Ravanelli <[email protected]>
jlebon
reviewed
Apr 24, 2025
ravanelli
force-pushed
the
pr/brew-node-image
branch
from
3c3ef1c to
1894f06
Compare
- Refactor get_rpm_list to allow packages from the new meta.json and extensions.json from the node-image Signed-off-by: Renata Ravanelli <[email protected]>
- cmd-koji-upload is tightly coupled to the Build class and cosalib internals, which makes supporting the new node-image layout challenging. This commit introduces a way to maintain compatibility with both the legacy and updated node-image styles for brew uploads. - This is a transitional fix — once the migration to Konflux is complete, this compatibility layer will no longer be necessary. Signed-off-by: Renata Ravanelli <[email protected]>
jlebon
force-pushed
the
pr/brew-node-image
branch
from
1894f06 to
f25a6ba
Compare
jlebon
approved these changes
Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmd-koji-upload is tightly coupled to the Build class and cosalib internals, which makes supporting the new node-image layout challenging.
This commit introduces a way to maintain compatibility with both the legacy and updated node-image styles for brew uploads.
This is a transitional fix — once the migration to Konflux is complete, this compatibility layer will no longer be necessary.