bios+ppc64le: Support being passed a whole device

[cgwalters]

And automatically find the PReP partition.

Closes: #837

[cgwalters]

This depends on containers/bootc#1086

[cgwalters]

OK I only compile tested this locally but if someone has a reproducer env, can you try e.g.:

FROM <rhel>
RUN <<EORUN
set -xeuo pipefail
rm /usr/lib/ostree-boot/loader -vrf
curl -Lf -o /usr/bin/bootupctl https://fedorapeople.org/~walters/bootupd-ppc64le
ln -f /usr/bin/bootupctl /usr/libexec/bootupd
EORUN

[HuijingHei]

Do testing on ppc64, failed to run update, here are the steps. Will look at it more tomorrow.

[root@cosa-devsh core]# rpm-ostree useroverlay
[root@cosa-devsh core]# curl -Lf -o /usr/bin/bootupctl https://fedorapeople.org/~walters/bootupd-ppc64le                                                                     
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current       
                                 Dload  Upload   Total   Spent    Left  Speed         
100 73.7M  100 73.7M    0     0  20.3M      0  0:00:03  0:00:03 --:--:-- 20.3M        
[root@cosa-devsh core]# ln -f /usr/bin/bootupctl /usr/libexec/bootupd                 
[root@cosa-devsh core]# bootupctl status                                                                                                                                     
Running as unit: bootupd.service; invocation ID: f943b7a8304c4835822ec13845bec43c                                                                                            
Component BIOS                                                                                                                                                               
  Installed: grub2-tools-1:2.12-15.fc41.ppc64le                                                                                                                              
  Update: At latest version                                                                                                                                                  
No components are adoptable.                                                                                                                                                 
CoreOS aleph version: 41.20250209.20.0                                                
[root@cosa-devsh core]# mount -o remount,rw /boot                                     
[root@cosa-devsh core]# rm -f /boot/bootupd-state.json                                                                                                                       
[root@cosa-devsh core]# bootupctl update -vvvv
[TRACE bootupd] executing cli                                                         
Running as unit: bootupd.service; invocation ID: e38c74b5f23e4163aea4fdab6f1f7cfc     
[TRACE bootupd] executing cli                                                         
[TRACE bootupd::bootupd] No saved state                                               
[TRACE bootupd::bootupd] Remaining known components: 1                                                                                                                       
[TRACE bootupd::component] Adoptable: ContentMetadata { timestamp: 2025-02-10T02:25:23.330Z, version: "41.20250209.20.0" }                                                   
[TRACE bootupd::component] Adoptable: ContentMetadata { timestamp: 2025-02-10T02:25:23.330Z, version: "41.20250209.20.0" }                                                   
[DEBUG bootupd::blockdev] Find parent devices: ["/dev/vda"]                                                                                                                  
error: Failed adopt and update: Failed to find PReP partition with GUID 9E1A2D38-C612-4316-AA26-8B49521E5A8B

[cgwalters]

OK yeah digging in we're hitting udev issues; lsblk -J -O doesn't pick up the partition UUIDs from inside a container even with -v /dev:/dev; I think we're missing some data from /run on the host.

We'll need to switch to sfdisk to directly parse the partition tables

[cgwalters]

OK, I've tested this one now in concert with containers/bootc#1106 and it looks like it works.

I did hit an issue when trying to use to-existing-root that took me a while to figure out - the host system was provisioned with RHEL10 and I was trying to install RHEL9, and the grub XFS probe failed to parse the too-new layout of the host filesystem. grub failing here is of course just the canary, the Linux kernel would also fail to parse it.

Ideally we figure out a generic way to probe this in containers/bootc#192

[root@cosa-devsh core]# curl -Lf -o /usr/bin/bootupctl https://fedorapeople.org/~walters/bootupd-ppc64le

I think I hadn't updated that binary with the latest from this PR before, but I have now. Want to retest?

[HuijingHei]

I understood the problem now, can reproduce using bootupd-0.2.26-1.fc41.ppc64le.

[root@cosa-devsh core]# bootupctl update -vvvvv
...
Installing for powerpc-ieee1275 platform.
/usr/sbin/grub2-install: error: the chosen partition is not a PReP partition.
error: Failed adopt and update: Failed to run "/usr/sbin/grub2-install" "--target" "powerpc-ieee1275" "--boot-directory" "/boot" "--no-nvram" "/dev/vda"

Sorry that it is introduced by 07c3661 which ignore the ppc64le platform.

Retest and run bootupctl update successfully using https://fedorapeople.org/~walters/bootupd-ppc64le.

[HuijingHei]

Just one minor suggestion, not blocker, better to rename target_device to get_prepboot_device(), and move it to src/blockdev.rs? I am also OK to keep it here as it is only used on ppc64.

[HuijingHei]

LGTM