Skip to content

refactor: improve npm package code #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: improve npm package code #171

wants to merge 1 commit into from
+42 −47

Conversation

@ocombe
Copy link
Contributor

@ocombe ocombe commented Oct 24, 2025 •
edited
Loading

  • Update Node.js version from 20 to 22 in CI
  • Update pnpm version from 8 to 10 in CI
  • Replace node-fetch with built-in fetch API
  • Prefix all Node.js core modules with 'node:' protocol
  • Extract platform/arch checks into isPlatform() utility function
  • Use parseArgs() for CLI argument parsing
  • Extract localhost validation into isLocalhost() function
  • Remove node-fetch dependency from package.json

rtimush
rtimush reviewed Oct 24, 2025
View reviewed changes
@ocombe ocombe force-pushed the fix/npm-package-fixes branch from ef6ffba to 00fcb0b Compare October 24, 2025 12:38
rtimush
rtimush approved these changes Oct 24, 2025
View reviewed changes
Copy link
Collaborator

@rtimush rtimush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but let's wait for @cx-shahar-kazaz'r review as well.

@ocombe ocombe force-pushed the fix/npm-package-fixes branch from 00fcb0b to c3213d9 Compare October 24, 2025 12:54
@ocombe
refactor: improve npm package code
44b9a52 
- Update Node.js version from 20 to 22 in CI
- Update pnpm version from 8 to 10 in CI
- Replace node-fetch with built-in fetch API
- Prefix all Node.js core modules with 'node:' protocol
- Extract platform/arch checks into isPlatform() utility function
- Use parseArgs() for CLI argument parsing
- Extract localhost validation into isLocalhost() function
- Remove node-fetch dependency from package.json
@ocombe ocombe force-pushed the fix/npm-package-fixes branch from c3213d9 to 44b9a52 Compare October 24, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rtimush rtimush rtimush approved these changes

@cx-shahar-kazaz cx-shahar-kazaz Awaiting requested review from cx-shahar-kazaz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ocombe @rtimush