-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] investor_wallet_platform_base: Store can_subscribe field on res.partner #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a small (non-blocking) remark, otherwise lgtm!
"share_type_ids", | ||
"share_type_ids.display_on_website", | ||
"share_type_ids.state", | ||
"loan_issue_ids", | ||
"loan_issue_ids.display_on_website", | ||
"loan_issue_ids.state", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"share_type_ids"
and "loan_issue_ids"
are not needed: only the deepest fields are needed.
….partner The consequence of this is that `write_date` will be bumped whenever the field is recomputed, which is a prerequisite for the web software by Cobea.
fd11277
to
b9e4fd5
Compare
/ocabot merge minor |
What a great day to merge this nice PR. Let's do it! |
@carmenbianca your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-93-by-carmenbianca-bump-minor. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
/ocabot merge minor |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 213c8dc. Thanks a lot for contributing to coopiteasy. ❤️ |
Description
The consequence of this is that
write_date
will be bumped whenever the field is recomputed, which is a prerequisite for the web software by Cobea.Odoo task (if applicable)
https://gestion.coopiteasy.be/web#id=10795&model=project.task&view_type=form&menu_id=
Checklist before approval