Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] investor_wallet_platform_base: Store can_subscribe field on res.partner #93

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

carmenbianca
Copy link
Member

Description

The consequence of this is that write_date will be bumped whenever the field is recomputed, which is a prerequisite for the web software by Cobea.

Odoo task (if applicable)

https://gestion.coopiteasy.be/web#id=10795&model=project.task&view_type=form&menu_id=

Checklist before approval

  • Tests are present (or not needed).
  • Credits/copyright have been changed correctly.
  • Change log snippet is present.
  • (If a new module) Moving this to OCA has been considered.

Copy link
Member

@huguesdk huguesdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small (non-blocking) remark, otherwise lgtm!

Comment on lines 291 to 294
"share_type_ids",
"share_type_ids.display_on_website",
"share_type_ids.state",
"loan_issue_ids",
"loan_issue_ids.display_on_website",
"loan_issue_ids.state",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"share_type_ids" and "loan_issue_ids" are not needed: only the deepest fields are needed.

….partner

The consequence of this is that `write_date` will be bumped whenever the
field is recomputed, which is a prerequisite for the web software by Cobea.
@carmenbianca carmenbianca force-pushed the 12.0-store-can_subscribe branch from fd11277 to b9e4fd5 Compare July 4, 2023 15:43
@carmenbianca
Copy link
Member Author

/ocabot merge minor

@github-grap-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-93-by-carmenbianca-bump-minor, awaiting test results.

github-grap-bot added a commit that referenced this pull request Jan 15, 2024
Signed-off-by carmenbianca
@github-grap-bot
Copy link
Contributor

@carmenbianca your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-93-by-carmenbianca-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@carmenbianca
Copy link
Member Author

/ocabot merge minor

@github-grap-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-93-by-carmenbianca-bump-minor, awaiting test results.

@github-grap-bot github-grap-bot merged commit e8c5df9 into 12.0 Jan 15, 2024
2 checks passed
@github-grap-bot github-grap-bot deleted the 12.0-store-can_subscribe branch January 15, 2024 15:28
@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at 213c8dc. Thanks a lot for contributing to coopiteasy. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants