vine: link_poll handle whole buffer #4054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btovar
requested changes
Feb 4, 2025
taskvine/src/manager/vine_manager.c
Outdated
| int workers_failed = 0; | ||
| // Then consider all existing active workers | ||
| for (i = j; i < n; i++) { | ||
| for (int i = 1; i < n; i++) { |
There was a problem hiding this comment.
Let's leave the int outside the for, as that's the way we do it in the rest of the code.
dthain
reviewed
Feb 4, 2025
dthain
approved these changes
Feb 5, 2025
btovar
pushed a commit
that referenced
this pull request
Feb 6, 2025
* read in whole link buffer * add break, formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
In one call to link_poll handle any additional messages in the buffer.
This appears to remove some latency between messages coming in.
Merge Checklist
The following items must be completed before PRs can be merged.
Check these off to verify you have completed all steps.
make testRun local tests prior to pushing.make formatFormat source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)make lintRun lint on source code prior to pushing.