Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vine: apply BYTES_TO_MEGABYTES when calculate inuse_cache #4029

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

JinZhou5042
Copy link
Member

@JinZhou5042 JinZhou5042 commented Jan 23, 2025

Proposed Changes

  • Apply BYTES_TO_MEGABYTES when converting bytes data into megabytes, instead of doing math.

  • There is a bug in doing w->resources->disk.total - w->inuse_cache, where the left side is in MB while the right side is in Bytes

Merge Checklist

The following items must be completed before PRs can be merged.
Check these off to verify you have completed all steps.

  • make test Run local tests prior to pushing.
  • make format Format source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)
  • make lint Run lint on source code prior to pushing.
  • Manual Update: Update the manual to reflect user-visible changes.
  • Type Labels: Select a github label for the type: bugfix, enhancement, etc.
  • Product Labels: Select a github label for the product: TaskVine, Makeflow, etc.
  • PR RTM: Mark your PR as ready to merge.

@JinZhou5042 JinZhou5042 self-assigned this Jan 23, 2025
@JinZhou5042 JinZhou5042 requested a review from btovar January 23, 2025 22:02
@btovar btovar merged commit 4f68974 into cooperative-computing-lab:master Jan 24, 2025
10 checks passed
@JinZhou5042 JinZhou5042 deleted the bytes2mb branch February 6, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants