Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vine: skip worker resource check for function calls #4028

Conversation

JinZhou5042
Copy link
Member

@JinZhou5042 JinZhou5042 commented Jan 23, 2025

Proposed Changes

The hack in #3913 that skipped the resource check for function calls was indeed the right way to do it...

And as the check for function calls are skipped, !t->needs_library becomes always true, thus the second half part of if (ti->provides_library && ti->function_slots_inuse == 0 && (!t->needs_library || strcmp(t->needs_library, ti->provides_library))) can be completely removed.

Merge Checklist

The following items must be completed before PRs can be merged.
Check these off to verify you have completed all steps.

  • make test Run local tests prior to pushing.
  • make format Format source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)
  • make lint Run lint on source code prior to pushing.
  • Manual Update: Update the manual to reflect user-visible changes.
  • Type Labels: Select a github label for the type: bugfix, enhancement, etc.
  • Product Labels: Select a github label for the product: TaskVine, Makeflow, etc.
  • PR RTM: Mark your PR as ready to merge.

@JinZhou5042 JinZhou5042 requested a review from dthain January 23, 2025 21:35
@JinZhou5042 JinZhou5042 self-assigned this Jan 23, 2025
@btovar btovar self-requested a review January 24, 2025 15:43
@btovar btovar merged commit 28462b2 into cooperative-computing-lab:master Jan 24, 2025
10 checks passed
btovar pushed a commit that referenced this pull request Jan 30, 2025
* vine: skip worker resource check for function calls

* comment
@JinZhou5042 JinZhou5042 deleted the skip_resources_check_for_function_calls branch February 6, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants