Prepare TS WASM Bindings From Existing Playground #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbolda
commented
May 28, 2025
| { | ||
| "name": "@cooklang/cooklang-ts", | ||
| "version": "0.0.0", | ||
| "private": "true", |
There was a problem hiding this comment.
Intentionally left this private until we are ready to move forward with this setup.
|
Looks great, thank you! |
dubadub
approved these changes
May 28, 2025
Zheoni
approved these changes
May 28, 2025
|
new structure looks good, although merging into main means that the playground will stop working in the main branch? If we merge knowing that I think it's fine. The other option is to have a separate branch for the ts bindings until they are in a working state. |
This should work in local and deployed unless there is something that I am missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We are establishing the TS bindings within this repo. The playground already has existing work to
wasm-packinto a parser available for use in the browser and JS targets which we can build upon.Changes
typescriptfoldertypescriptfolder to properly build and allow continued deployment of the playgroundwatchscript to rerunwasm-packon changes to the Rust based parser