Skip to content

Conversation

yurtpage
Copy link
Contributor

The biggest problem of the xmpp: links is that they won't work without installed client. So here is web based https://xmpp.link/
similar to Matrix.to or t.me for Telegram.
In the PR I added the web link that can be copied by a user shared.

  • Add a changelog entry for your change in CHANGES.md
  • When adding a configuration variable, please make sure to
    document it in docs/source/configuration.rst
  • Please add a test for your change. Tests can be run in the commandline
    with make check or you can run them in the browser by running make serve
    and then opening http://localhost:8000/tests.html.

@marclaporte
Copy link
Member

Thank you @yurtpage

What happens if this domain name is not renewed in a few years?

@yurtpage
Copy link
Contributor Author

yurtpage commented Sep 22, 2025

In 99% this won't be a problem because a typical usage is a short living invitations. For the long standing links it's more likely that a user or channel disappear than the domain expires.
The service provided by Modern XMPP which is same people as Prosody and Snikket, so it can be trusted to some extent.
Sources are here https://github.com/modernxmpp/easy-xmpp-invitation
The Kaidan client has own instance of the service on own domain https://i.kaidan.im/
The Conversations client also has "HTTP link" to share your account but it uses own service that is not open sourced.

Sorry, I had to make it configurable and translatable but I can do this only later.

@jcbrand
Copy link
Member

jcbrand commented Sep 24, 2025

Thanks @yurtpage, but I think a better approach would be to open those links inside Converse (which AFAIK is doable), given that the user is already seeing them inside an instance of Converse.

It doesn't make sense to me to be inside Converse, click an XMPP link and then be taken somewhere else...

@marclaporte
Copy link
Member

Ok then, perhaps material for a "Good first issue"?

@jcbrand
Copy link
Member

jcbrand commented Sep 24, 2025

@marclaporte There is actually an old ticket for this: #1247

I've added the Good first issue label, although I'm not sure the complexity involved.

@yurtpage
Copy link
Contributor Author

This a link to share so you can send to a friend or publish in internet. The Converse.js have nothing to do with them

@jcbrand
Copy link
Member

jcbrand commented Sep 25, 2025

This a link to share so you can send to a friend or publish in internet. The Converse.js have nothing to do with them

Ok, but the fields that you modified in this PR don't say that, they say "XMPP Address" and with your PR's change the value that is shown for that field is not an XMPP address anymore but a web URL.

If we want to add these links, then I think they should go in a new field, called something like "Shareable link", so that it's clear that this is a URL meant to be shared with others.

This option would also have to be configurable, since Converse can be used in setups where other clients cannot be used, in which case such a link is not usable and confusing.

@yurtpage
Copy link
Contributor Author

Let's make two buttons instead "Copy address" and "Copy invitation web link".

@yurtpage yurtpage marked this pull request as draft September 26, 2025 10:23
@jcbrand
Copy link
Member

jcbrand commented Oct 7, 2025

Let's make two buttons instead "Copy address" and "Copy invitation web link".

I don't think the buttons should have these labels, instead we can just use normal labels and then have a small button with a copy icon next to the value.

For example: 👇

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants