-
-
Notifications
You must be signed in to change notification settings - Fork 800
Web link for XMPP address via xmpp.link #3852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thank you @yurtpage What happens if this domain name is not renewed in a few years? |
In 99% this won't be a problem because a typical usage is a short living invitations. For the long standing links it's more likely that a user or channel disappear than the domain expires. Sorry, I had to make it configurable and translatable but I can do this only later. |
Thanks @yurtpage, but I think a better approach would be to open those links inside Converse (which AFAIK is doable), given that the user is already seeing them inside an instance of Converse. It doesn't make sense to me to be inside Converse, click an XMPP link and then be taken somewhere else... |
Ok then, perhaps material for a "Good first issue"? |
@marclaporte There is actually an old ticket for this: #1247 I've added the |
This a link to share so you can send to a friend or publish in internet. The Converse.js have nothing to do with them |
Ok, but the fields that you modified in this PR don't say that, they say "XMPP Address" and with your PR's change the value that is shown for that field is not an XMPP address anymore but a web URL. If we want to add these links, then I think they should go in a new field, called something like "Shareable link", so that it's clear that this is a URL meant to be shared with others. This option would also have to be configurable, since Converse can be used in setups where other clients cannot be used, in which case such a link is not usable and confusing. |
Let's make two buttons instead "Copy address" and "Copy invitation web link". |
The biggest problem of the
xmpp:
links is that they won't work without installed client. So here is web based https://xmpp.link/similar to Matrix.to or t.me for Telegram.
In the PR I added the
web
link that can be copied by a user shared.CHANGES.md
document it in
docs/source/configuration.rst
with
make check
or you can run them in the browser by runningmake serve
and then opening
http://localhost:8000/tests.html
.