feat: add metrics and timing functions #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: we need to record timing of things Solution: this adds a metrics table to the database, which is accessible directly by the same rainbow server that holds the database, and otherwise (for clients that are not directly connected) it can be sent metrics to save. Saving means a name, value, and arbitrary set of key value pairs (both strings). I am also including a pythons script that shows how to read the rainbow database and output the tables. Signed-off-by: vsoch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: we need to record timing of things
Solution: this adds a metrics table to the database, which is accessible directly by the same rainbow server that holds the database, and otherwise (for clients that are not directly connected) it can be sent metrics to save. Saving means a name, value, and arbitrary set of key value pairs (both strings). I am also including a pythons script that shows how to read the rainbow database and output the tables.
This won't be merged, but we can keep in sync with upstream.