Skip to content

fix: Ignore invalid JSON messages (like NODE_ENV undefined) #6576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2025

Conversation

exigow
Copy link
Collaborator

@exigow exigow commented Jul 11, 2025

Fixes: https://continue-xd.sentry.io/issues/6731751693


Summary by cubic

Invalid JSON messages (like when NODE_ENV is undefined) are now ignored instead of causing errors in the plugin.

  • Bug Fixes
  • Added error handling to skip and log invalid JSON messages.

Copy link

netlify bot commented Jul 11, 2025

Deploy Preview for continuedev failed. Why did it fail? →

Name Link
🔨 Latest commit ad8f559
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/68710086ed7fa0000854783b

@exigow
Copy link
Collaborator Author

exigow commented Jul 11, 2025

Marking as draft because I need to fix TODOs + check this changes manually on Monday (we have issues with infra today).

@exigow exigow marked this pull request as ready for review July 14, 2025 10:14
@exigow exigow requested a review from a team as a code owner July 14, 2025 10:14
@exigow exigow requested review from tomasz-stefaniak and removed request for a team July 14, 2025 10:14
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 14, 2025
Copy link

⚠️ Conventional Commit Format

Your commit messages don't follow the conventional commit format, but this won't block your PR from being merged. We recommend downloading this extension if you are using VS Code.

Expected Format:

<type>[optional scope]: <description>

[optional body]

[optional footer(s)]

Examples:

  • feat: add changelog generation support
  • fix: resolve login redirect issue
  • docs: update README with new instructions
  • chore: update dependencies

Valid Types:

feat, fix, docs, style, refactor, perf, test, build, ci, chore, revert

This helps with:

  • 📝 Automatic changelog generation
  • 🚀 Automated semantic versioning
  • 📊 Better project history tracking

This is a non-blocking warning - your PR can still be merged without fixing this.

@exigow exigow requested review from Patrick-Erichsen and removed request for tomasz-stefaniak July 17, 2025 14:17
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jul 21, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 21, 2025
@Patrick-Erichsen Patrick-Erichsen merged commit 52e2f3c into main Jul 21, 2025
43 checks passed
@Patrick-Erichsen Patrick-Erichsen deleted the exigow/ignore-invalid-json-messages branch July 21, 2025 21:37
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jul 21, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2025
@sestinj
Copy link
Contributor

sestinj commented Jul 22, 2025

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Jul 24, 2025

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer released size:S This PR changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants