feat: add build script and enhance OAuth token handling #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shobhitupadhyayy
commented
Sep 4, 2025
shobhitupadhyayy
commented
- Introduced a new build.sh script for region selection and OAuth login.
- Added app.json to .gitignore and included manifest.json in API .gitignore.
- Updated package dependencies for improved functionality.
- Implemented saveOAuthToken endpoint for secure token handling.
- Enhanced region configuration and API host management in constants.
- Added error handling and logging improvements in auth service.
- Introduced a new build.sh script for region selection and OAuth login. - Added app.json to .gitignore and included manifest.json in API .gitignore. - Updated package dependencies for improved functionality. - Implemented saveOAuthToken endpoint for secure token handling. - Enhanced region configuration and API host management in constants. - Added error handling and logging improvements in auth service.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces OAuth authentication functionality with multi-region support for a Contentstack migration application. It adds comprehensive OAuth token handling, region configuration management, and automated setup workflows.
- Adds OAuth authentication flow with PKCE security implementation
- Introduces multi-region support with automated region selection and configuration
- Implements secure token storage and refresh mechanisms with database persistence
Reviewed Changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| build.sh | New setup script for region selection, OAuth login, and migration execution |
| api/sso.utils.js | OAuth configuration utility with multi-region support and app management |
| api/src/services/auth.service.ts | Enhanced auth service with OAuth token handling and refresh functionality |
| api/src/routes/auth.routes.ts | New OAuth token save endpoint route |
| api/src/models/types.ts | Added RefreshTokenResponse interface for OAuth responses |
| api/src/controllers/auth.controller.ts | New controller method for OAuth token handling |
| api/src/constants/index.ts | Regional API host configurations for OAuth endpoints |
| api/package.json | Updated dependencies including marketplace SDK and express-session |
| api/.gitignore | Added manifest.json to ignored files |
| .talismanrc | Updated security scan configuration with new file checksums |
Files not reviewed (1)
- api/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
api/src/services/auth.service.ts:1
- The openBrowser function is called but not defined or imported. This will cause a runtime error.
import { Request } from "express";
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…cies - Removed redundant variables for client_id and client_secret in saveOAuthToken function. - Updated logging to use a centralized logger instead of console methods. - Removed unnecessary deletion of code_verifier from the request session. - Updated package.json to remove outdated "api" dependency.
- Modified build.sh to append '/v2/auth/save-token' to the redirect_uri. - Updated auth.service.ts to use the correct redirect_uri for token requests. - Ensured consistency in region configuration and API endpoint handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.