Fix/config singleton pattern#2014
Merged
AniketDev7 merged 13 commits intodevelopmentfrom Jul 24, 2025
Merged
Conversation
- Remove NODE_ENV check that was causing null config in development - Update package versions to latest compatible versions - Add version management script for maintaining dependency consistency - Fix authentication handler issues with OCLIF v4
- Add lazy initialization pattern to prevent unnecessary config operations - Initialize config only when methods are actually called - Add documentation explaining the lazy initialization pattern - Keep all existing functionality intact
…ialization changes
aman19K
previously approved these changes
Jul 24, 2025
aman19K
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Lazy Initialization Pattern for Config Handler
Problem
After upgrading to OCLIF v4, we encountered initialization issues with the config handler being initialized upon import, causing failures in the GoCD pipeline environment. This was particularly problematic because plugins that imported but didn't use the config were still triggering initialization.
Solution
Implemented a lazy initialization pattern for the Config class where:
configproperty is nownullby defaultinitializeIfNeeded()method to handle lazy initializationKey Changes
Modified
Configclass to use lazy initialization:initializeIfNeeded()method for on-demand initializationinitializeIfNeeded()Documentation:
Benefits
Testing
Breaking Changes
None. This is a non-breaking change as all public methods maintain their existing signatures and behavior.