[DX-3281] fix: Skip stack settings import when using management token#2010
Merged
AniketDev7 merged 1 commit intodevelopmentfrom Jul 22, 2025
Merged
Conversation
- Skip stack settings import operation when using management token alias to prevent 'Session timed out' errors - Add management token check in ImportStack.start() method similar to export fix in PR #1983 - Fix sanitizeStack function call in module-importer to pass correct parameter - Add management token protection to sanitizeStack function to prevent stack version API timeouts - Ensures consistent behavior between import and export commands with management tokens Fixes timeout issue: 'Stack failed to be imported! Session timed out, please login to proceed'
aman19K
reviewed
Jul 22, 2025
aman19K
approved these changes
Jul 22, 2025
netrajpatel
approved these changes
Jul 22, 2025
Contributor
|
@AniketDev7 can you add sanity report ? this PR will be a reference |
Contributor
Author
Hi @shafeeqd959 The sanity report link is already shared while requesting the PR review itself and u r tagged in the slack channel thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Description
The import command fails with "Session timed out, please login to proceed" error when using management token alias (
-aflag) due to unsupported stack settings operations.Root Cause
PR #1979 added stack settings import functionality but didn't include management token handling, causing timeout errors similar to what was fixed for export in PR #1983.
Solution
Applied the same management token protection pattern from export fix (PR #1983) to the import functionality.
Changes Made:
stack.ts): SkipaddSettingsoperation when using management tokenmodule-importer.ts): FixedsanitizeStackfunction call parametercommon-helper.ts): Added management token protection tosanitizeStackExisting Auth Methods (--stack-api-key, OAuth):
Backward Compatibility
📋 Checklist
Related