Fixed seed command issue when selecting the existing stack#2009
Closed
sunil-lakshman wants to merge 13 commits intodevelopmentfrom
Closed
Fixed seed command issue when selecting the existing stack#2009sunil-lakshman wants to merge 13 commits intodevelopmentfrom
sunil-lakshman wants to merge 13 commits intodevelopmentfrom
Conversation
netrajpatel
requested changes
Jul 21, 2025
shafeeqd959
reviewed
Jul 21, 2025
Contributor
|
@sunil-lakshman Make use of this change to fix the existing test cases |
shafeeqd959
reviewed
Jul 22, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with the seed command when selecting existing stacks. The main change updates the CLI seed dependency version from 1.11.3 to 1.11.4, which contains refactored code for better handling of existing stack selection, particularly for Compass app requirements.
Key changes:
- Updates the @contentstack/cli-cm-seed dependency to version 1.11.4
- Refactors seed logic to properly handle existing stack selection for Compass apps
- Extracts Compass-specific validation logic into a dedicated helper module
Reviewed Changes
Copilot reviewed 19 out of 21 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/contentstack/package.json | Updates main CLI version to 1.43.2 and seed dependency to ~1.11.4 |
| packages/contentstack-seed/src/seed/index.ts | Refactors seed logic with better error handling and extracted Compass validation |
| packages/contentstack-seed/src/seed/compassAppHelper.ts | New helper module containing Compass app-specific validation logic |
| packages/contentstack-seed/package.json | Bumps seed package version to 1.11.4 |
| Multiple README files | Updates version numbers and Node.js version in usage examples |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
packages/contentstack-seed/src/seed/compassAppHelper.ts:8
- [nitpick] The token name is redundant with the description. Consider making it more descriptive like 'Compass App Management Token' or use a unique identifier.
"name":"This is a compass app management token",
Contributor
|
@sunil-lakshman entire seed handler being revamped in this please do make sure we test all cases, |
Contributor
|
@sunil-lakshman can you fix the current test cases and add them here |
shafeeqd959
previously approved these changes
Jul 23, 2025
Added unit testcases for contentstack seed plugin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.