Fix/dx 2973 export stack settings#1960
Merged
harshithad0703 merged 23 commits intodevelopmentfrom Jul 3, 2025
Merged
Conversation
… related functionality for clarity
…-import-stack-settings
…port-import-stack-settings
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the stack export feature by including branch names in export paths and adding a dedicated method to export stack settings, along with cleanup in rate-limit and audit modules.
- Include
branchNamewhen resolving the export folder path for a stack - Add
exportStackSettings()to write stack settings tosettings.json - Remove unused imports and refine error logging in rate-limit and audit code
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/contentstack-export/src/export/modules/stack.ts | Updated stackFolderPath to include branchName and added exportStackSettings() |
| packages/contentstack-config/src/utils/rate-limit-handler.ts | Removed unused formatError import and cleaned up error logging |
| packages/contentstack-config/src/commands/config/set/rate-limit.ts | Imported formatError and revised CLI error messages in the set-rate-limit command |
| packages/contentstack-audit/src/modules/entries.ts | Refactored title sanitization logic and changed removeEmojiAndImages implementation |
| .talismanrc | Updated checksum for package-lock.json ignore entry |
Comments suppressed due to low confidence (2)
packages/contentstack-config/src/commands/config/set/rate-limit.ts:87
- [nitpick] This duplicates the error output and may log an object directly. Consolidate messages—use
formatError(error)orerror.messageconsistently and remove the extracliux.error(error).
cliux.error(error);
packages/contentstack-audit/src/modules/entries.ts:845
- The removal of optional chaining (
?.) meansremoveEmojiAndImageswill throw onundefinedinput. Restore safety by reintroducingstr?.replaceor validatestrfirst.
return str.replace(
aman19K
previously approved these changes
Jun 10, 2025
…n and package-lock.json
cs-raj
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.