-
Notifications
You must be signed in to change notification settings - Fork 81
Implement Debug
w/ detailed manifest for Reader
#473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Serialize
and custom Debug
for Reader
Debug
w/ detailed manifest for Reader
33eb8e7
to
81b428b
Compare
Adding |
0931c35
to
34afb35
Compare
34afb35
to
5cefa62
Compare
For now we require |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Changes in this pull request
Store
field toManifestStore
to open access to allStore
methods and allow constructing aManifestStoreReport
on the flyDebug
forReader
, providing the user with detailed debug information about the manifest (effectively exposingManifestStoreReport
in the unstable API)Notes
Reader
already implementsDisplay
, providing user-friendly information about the manifest, whereasDebug
provides detailed info viaManifestStoreReport
.ManifestStoreReport::dump_tree
andManifestStoreReport::cert_chain
in the unstable API?Manifest::certificates
, could be usefulChecklist
TO DO
items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.