fix: to_archive and task threads #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adobe SDK extends the builder for compliance signing.
fixes to_archive work with buffers as well as files. Settings work on Neon/Node tasks
tmathern
approved these changes
Dec 16, 2025
| let promise = cx | ||
| .task(move || { | ||
| // Block on acquiring the async mutex lock | ||
| // Settings are automatically applied when runtime() is called |
There was a problem hiding this comment.
We should ask again when we'll get the definitive Settings API. It would be easier and more elegant to jsut pass settings through per Reader/Builder. Following Settings per thread will give me headaches.
* Update trustmark version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes to_archive work with buffers as well as files.
Settings work on Neon/Node tasks