Python 3 support improvements + bug fixes + new command line argument #6
+96
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should be hex dumped (e.g. to view XMP boxes)
|
Great, let me know if I can help! |
|
@bquinn I have rolled all your non-buffer-limit fixes in. I'd like to look at reapplying those after all the python3, etc. fixes are in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes from @tbr and myself for Python 3 support. Also adding a new command line parameter "buffer-print-limit" which lets the caller determine the maximum size of buffers that should be output as hex dumps. This in particular lets us view XMP blocks that were previously hidden.
Feel free to change the name "buffer-print-limit" if you have any better ideas!