Increase PHPStan level #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Level 6 works now, but we should probaly revert 8bd8415 and find out what the issue is here. |
|
We should maybe rethink if we really need both PhpStan and Psalm. 🙈 |
leofeyer
reviewed
Jul 15, 2020
|
I would merge this as it is now, and create a new PR that reverts the |
|
I would prefer to wait until the PHPStan devs have signaled that they want to fix phpstan/phpstan-phpunit#77. I am not that big a fan of merging pointless workarounds into production code just to fix issues in some dev tools. |
|
The workaround only affects the |
|
Ok, that's better than. Still a pointless workaround. 🙈 |
|
Pull request that reverts the workaround: #27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Level 6 seems impossible because psalm fights the changes required for phpstan.Fixed by adding@phpstan-and@psalm-type annotations.But the level 5 changes can be used I think.
/cc @m-vo