add optional image tag filter #2054
Open
+39
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
I originally wrote the code for the ?image parameter in #1289 and made it ignore the specific tag. To be honest, I forgot why I did it like that, and it's now causing problems for me. What's the status on this? It looks good to me. |
Foxite
approved these changes
Apr 13, 2025
|
I am using this for a few months in production and it works. |
|
I noticed this project seems dead; I'm examining forks by nicholas-fedor and beatkind to see if this can be incorporated there. |
|
@BenjaminFaal are you hosting your fork image somewhere? If so, I think I'll just use yours. |
Foxite
added a commit
to Foxite/nicholas-fedor-watchtower
that referenced
this pull request
Apr 13, 2025
nicholas-fedor
added a commit
to nicholas-fedor/watchtower
that referenced
this pull request
Apr 14, 2025
* adapt work from containrrr#2054 * feat: add image tag filtering to `FilterByImage` and update docs - Refactor `FilterByImage` to support optional tag matching with helper function `matchImageAndTag` - Add tests for malformed image inputs in `filters_test.go` - Update `http-api-mode.md` to document tag support in /v1/update endpoint - Add reference in `arguments.md` for tag filtering discoverability * chore(filters): add missing newline to satisfy linting * test(gotify): add gotify HTTP warning test to `notifier_test.go` - Add test for insecure HTTP URL warning in gotify notifier initialization * docs(readme): reorder recent contributor --------- Co-authored-by: Nick Fedor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to do finegrained updates to container running a specific tag of an image i added this.
closes #1932