-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Feature/podman container runlabel docs 26379 #26750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/podman container runlabel docs 26379 #26750
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM, but I'm not sure if the commit with examples of the --filter
flag should be part of this PR. If so, no problem, but please update the PR description.
Update: This PR depends on #26740 |
Thanks for clarifying. You will need to rebase this PR onto the main branch using the command |
Signed-off-by: mohitjain1911 <[email protected]>
a6969e0
to
7c95cea
Compare
@Honny1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Honny1, Luap99, mohitjain1911 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a154401
into
containers:main
What this PR does / why we need it:
This PR adds an example to the
podman-container-runlabel
manpage demonstrating usage of the--replace
flag. The example shows how the flag allows a runlabel command to be executed multiple times without failing, even if the label uses a fixed container name.Which issue(s) this PR fixes:
Fixes: #26379
Does this PR introduce a user-facing change?
Yes, it adds a new example to the manpage.