Skip to content

Conversation

mohitjain1911
Copy link
Contributor

@mohitjain1911 mohitjain1911 commented Aug 5, 2025

What this PR does / why we need it:

This PR adds an example to the podman-container-runlabel manpage demonstrating usage of the --replace flag. The example shows how the flag allows a runlabel command to be executed multiple times without failing, even if the label uses a fixed container name.

Which issue(s) this PR fixes:

Fixes: #26379

Does this PR introduce a user-facing change?

Yes, it adds a new example to the manpage.

docs: add example for --replace in podman container runlabel manpage

@openshift-ci openshift-ci bot added do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None release-note and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Aug 5, 2025
Copy link
Member

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM, but I'm not sure if the commit with examples of the --filter flag should be part of this PR. If so, no problem, but please update the PR description.

@Honny1
Copy link
Member

Honny1 commented Aug 5, 2025

Update: This PR depends on #26740

@mohitjain1911
Copy link
Contributor Author

mohitjain1911 commented Aug 5, 2025

Hi @Honny1
Thanks for reviewing these PR
I have first created a branch and then raised PR #26740 for Ticket #26351
Then I picked another ticket today that is #26379 and raised another PR #26750 with new branch

@Honny1
Copy link
Member

Honny1 commented Aug 5, 2025

Thanks for clarifying. You will need to rebase this PR onto the main branch using the command git rebase -i upstream/main and remove the commit with examples using the --filter flag.

@mohitjain1911 mohitjain1911 force-pushed the feature/podman-container-runlabel-docs-26379 branch from a6969e0 to 7c95cea Compare August 5, 2025 12:34
@mohitjain1911
Copy link
Contributor Author

@Honny1
Thanks for you help!
I’ve successfully rebased the branch onto main and removed the extra commit as suggested.

Copy link
Member

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mheon
Copy link
Member

mheon commented Aug 5, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2025
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

openshift-ci bot commented Aug 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Honny1, Luap99, mohitjain1911

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit a154401 into containers:main Aug 5, 2025
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manpages: podman container runlabel missing example with --replace
4 participants