quadlet: generate RequiresMountsFor for Type=bind volumes #26282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
|
Thanks for the contribution. In order to make the test actually run you need to also add it to the array: podman/test/e2e/quadlet_test.go Line 881 in 17e9ada |
alaviss
force-pushed
the
push-wotrztyxpmou
branch
from
e50f254 to
b687691
Compare
This makes sure that the volume source is available before the volume is created. Fixes: containers#26125 Signed-off-by: Hiếu Lê <[email protected]>
alaviss
force-pushed
the
push-wotrztyxpmou
branch
from
b687691 to
18ecd20
Compare
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alaviss, Luap99, ygalblum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 5ff067c
into
containers:main
76 of 77 checks passed
stale-locking-app
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that the volume source is available before the volume is created.
Fixes: #26125
Does this PR introduce a user-facing change?