Fix incremental builds using make #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add .PHONY to to the release and debug library targets so running make does the right thing after changing the source. It is possible to use cargo directly, but this means a developer need to also run the more commands manually for each build which is error prone. Signed-off-by: Nir Soffer <[email protected]>
nirs
requested review from
MatiasVara,
mtjhrc,
slp and
tylerfanelli
as code owners
|
This is annoying indeed! 😄, but I have already fixed it as part of: #258, here: 010e99d Maybe I could have fixed it as a separate PR, but it seemed quite simple and related to adding a |
mtjhrc
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add .PHONY to to the release and debug library targets so running make does the right thing after changing the source.
It is possible to use cargo directly, but this means a developer need to also run the more commands manually for each build which is error prone.