tests/verity-forking: Limit execution time to 10s #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was running over 60s on my machine (32 cores); digging in it's because the raw variant was simply not getting anywhere close to hitting 100 successes. First, rework to use a JoinSet instead of a tokio::join! so we see the completions as they come in instead of waiting for all of them. Add a hard limit of execution time of 10s. Add an assertion that the *copy* variant succeeds at least once. For the other two, we can't really make any assertions at all. Signed-off-by: Colin Walters <[email protected]>
|
LGTM |
Johan-Liebert1
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was running over 60s on my machine (32 cores); digging in it's because the raw variant was simply not getting anywhere close to hitting 100 successes.
First, rework to use a JoinSet instead of a tokio::join! so we see the completions as they come in instead of waiting for all of them.
Add a hard limit of execution time of 10s.
Add an assertion that the copy variant succeeds at least once. For the other two, we can't really make any assertions at all.