add MAC, IPv4, IPv6 addresses to nework inspect #4680
+102
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arjun Raja Yogidas <[email protected]>
coderbirju
force-pushed
the
add-details-network-inspect
branch
from
2385db1 to
eb356cf
Compare
haytok
reviewed
Jan 10, 2026
Comment on lines
+445
to
+452
| // Test IPv4 address field exists in response | ||
| assert.Assert(t, true, "IPv4Address field exists: %q", container.IPv4Address) | ||
|
|
||
| // Test MAC address field exists in response | ||
| assert.Assert(t, true, "MacAddress field exists: %q", container.MacAddress) | ||
|
|
||
| // Test IPv6 address field exists in response | ||
| assert.Assert(t, true, "IPv6Address field exists: %q", container.IPv6Address) |
Member
There was a problem hiding this comment.
Since true is specified, the test will pass under any circumstances. I think we need tests corresponding to the container variable.
| } | ||
|
|
||
| // Use the primary interface if available, otherwise use the first valid interface | ||
| if x.Index == container.Process.NetNS.PrimaryInterface || endpoint.IPv4Address != "" { |
Member
There was a problem hiding this comment.
Looking at another function that determines whether it's PrimaryInterface, is this processing really necessary?
nerdctl/pkg/containerinspector/containerinspector_linux.go
Lines 66 to 75 in 015837c
I'm not very familiar with PrimaryInterface, so I'd like to hear other maintainers' opinions as well 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current network inspect respone provides only container names
This PR adds other fields in the EndpointResource Struct