update containerd version to 2.1.0 #4217
Conversation
Shubhranshu153
force-pushed
the
upgrage-containerd-2.1
branch
3 times, most recently
from
52ee64d to
e427203
Compare
pkg/testutil/testutil_darwin.go
Outdated
| @@ -31,5 +31,5 @@ var ( | |||
| BusyboxImage = "ghcr.io/containerd/busybox:1.36" | |||
| AlpineImage = mirrorOf("alpine:3.13") | |||
| NginxAlpineImage = mirrorOf("nginx:1.19-alpine") | |||
| GolangImage = mirrorOf("golang:1.18") | |||
| GolangImage = mirrorOf("golang:1.23") | |||
There was a problem hiding this comment.
Heads-up @Shubhranshu153 .
See https://github.com/containerd/nerdctl/blob/main/docs/multi-platform.md#macos--lima
Tread carefully with this.
Unfortunately, the mirrored images we are using are not multiplatform.
Since this specifically is for Darwin (which is not using it, actually), we are fine, but the same change in _linux would break hell loose on arm.
There was a problem hiding this comment.
thanks. But in that case the test would fail using that image right or do we expect some unrecoverable issue?
There was a problem hiding this comment.
Any test involving building with that image would hard fail.
@AkihiroSuda got bitten by this: #4215
(though again that would be if you change it for linux as well, which you are not doing here)
There was a problem hiding this comment.
this is already set for all platform here #4215
There was a problem hiding this comment.
Could you rebase and revert this line, then LGTM
There was a problem hiding this comment.
reverted this change and rebased
|
Linking failures:
|
Signed-off-by: Shubharanshu Mahapatra <[email protected]>
Shubhranshu153
force-pushed
the
upgrage-containerd-2.1
branch
from
e427203 to
8b85431
Compare
Upgrading containerd version to 2.1.0