Replace getter functions with properties for meta access#256
Open
anuraaga wants to merge 1 commit into
Open
Conversation
Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
anuraaga
force-pushed
the
metadata-properties
branch
from
8a68535 to
4d8684f
Compare
stefanvanburen
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This highly breaking change has been a long time coming - I completely messed these APIs up in the first place as it's clearly more idiomatic to use properties for them. The next release will be one to target large breaking changes for.
On the bright side, it shouldn't affect most business logic, mostly just interceptors.
I have eagerly bumped the connect-python version so connectrpc-otel is also set up. If needing a patch release before that, will figure it out then