[KIP-848] Fix static group membership #4994
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
the contract is changed to be the same as the Java client, the member only releases partitions on session.timeout.ms reached. KIP-1092 to be implemented in a separate PR to leave permanently the group with static membership before session.timeout.ms is reached. When a new member joins the group and there's already a member with same group instance id that hasn't left statically the incoming member is fenced
airlock-confluentinc
bot
force-pushed
the
dev_kip848_fix_static_group_membership_leave
branch
from
eda7068 to
dfbf7e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are three cases for static group membership this PR fixes the first one:
When a new member joins the group and there's already a member with same group instance id that hasn't left statically the new member is fenced with the new protocol
Warning
The test won't work until regex implementation is merged