Added extendLease as task_router param #213
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@v1r3n Could you please review it? |
shivamsngh
approved these changes
Feb 2, 2024
|
Is there any reason this wasn't merged? |
|
Hi @dorzeidman can you resolve the conflicts and will take a look. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extendLeaseset toTruewon't be rescheduled by the Conductor unless it gets timed out withRETRYset as timeoutPolicy.Note: The feature is already implemented on the Conductor core and Java client. Just the task_router needs to be updated on Python's client side.
Discussion ref: Netflix/conductor#1378