Add installer hashes to info.json - #1327
Merged
Merged
Conversation
conda-bot
added
the
cla-signed
Jrice1317
marked this pull request as ready for review
August 13, 2026 02:23
lrandersson
reviewed
Aug 13, 2026
marcoesters
reviewed
Aug 13, 2026
Comment on lines
+61
to
+64
| if isinstance(algorithm, str): | ||
| algorithms.add(algorithm) | ||
| elif algorithm: | ||
| algorithms.update(algorithm) |
Contributor
There was a problem hiding this comment.
We need to validate that the hash algorithms are valid. It looks like that part of the code got removed.
Contributor
Author
There was a problem hiding this comment.
It didn't get removed completely. It got moved here.
Contributor
There was a problem hiding this comment.
Ah, yes, thanks for pointing that out! It looks like the test catching that ValueError got removed though, so we are missing some test coverage.
Contributor
Author
There was a problem hiding this comment.
The ValueError is in utils.py now.
| outpath = Path(f"{installer}.{algo}") | ||
|
|
||
| with open(outpath, "w", newline="\n") as f: | ||
| f.write(f"{info['_installer_hashes'][algo]} {installer.name}\n") |
Contributor
There was a problem hiding this comment.
This should have a guard to make sure we don't have an uncaught exception here. That way, we can have a more meaningful error message.
Co-authored-by: Robin <34315751+lrandersson@users.noreply.github.com>
marcoesters
approved these changes
Aug 19, 2026
lrandersson
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds installer hashes to info.json so downstream tooling can use it as a single source of truth for installer checksums.
Changes:
Test expectations:
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?