-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Adding pio r package as r-pio #29543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! This is the friendly automated conda-forge-linting service. I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14088621076. Examine the logs at this URL for more detail. |
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/r-pio/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14176086676. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
version: {{ version }} | ||
|
||
source: | ||
url: https://github.com/caravagn/pio/archive/refs/tags/{{ version }}.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, we prefer to work downstream of CRAN. Is there a reason why this package cannot first be deposited there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, the reason that the pio package is not on CRAN is that there are similar packages now hosted on CRAN that do the same thing since it is input output highlighting. However, we are in the process of submitting a nextflow pipeline to the nf-core repository that is made up of many previous packages from our lab that are dependent on pio, as at one point our pio package was the only one that gave us the output format we prefer. The nf-core maintainers requested that we repackage some of our custom modules in our submitted pipeline to be standard nf-core modules, which require that they are available in conda. In order to create the conda environment for these modules we first need pio to be available on conda-forge, but did not necessarily plan to submit pio to CRAN since nowadays there are similar packages available. Pio is stable, if it helps, with no need for updates in the past 5 years even with all of our other packages being dependent on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend submitting this to Bioconda instead. You can also ping me there for review/merge.
CC: @conda-forge/bioconda-recipes
recipes/r-pio/meta.yaml
Outdated
@@ -0,0 +1,63 @@ | |||
{% set name = "r-pio" %} | |||
{% set version = "v1.0.0" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tag shows v1.0.0
, but the DESCRIPTION file shows v0.1.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, I will bump the version number and repackage
Closing, since this is merged on Bioconda (bioconda/bioconda-recipes#55213). |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).