Skip to content

Adding pio r package as r-pio #29543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from

Conversation

brandon-hastings
Copy link

@brandon-hastings brandon-hastings commented Mar 26, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14088621076. Examine the logs at this URL for more detail.

Copy link
Contributor

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/r-pio/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: BrandonHastings. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/r-pio/meta.yaml) and found it was in an excellent condition.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Mar 31, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/r-pio/meta.yaml) and found some lint.

Here's what I've got...

For recipes/r-pio/meta.yaml:

  • ❌ Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [45, 46]

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14176086676. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/r-pio/meta.yaml) and found it was in an excellent condition.

version: {{ version }}

source:
url: https://github.com/caravagn/pio/archive/refs/tags/{{ version }}.tar.gz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, we prefer to work downstream of CRAN. Is there a reason why this package cannot first be deposited there?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, the reason that the pio package is not on CRAN is that there are similar packages now hosted on CRAN that do the same thing since it is input output highlighting. However, we are in the process of submitting a nextflow pipeline to the nf-core repository that is made up of many previous packages from our lab that are dependent on pio, as at one point our pio package was the only one that gave us the output format we prefer. The nf-core maintainers requested that we repackage some of our custom modules in our submitted pipeline to be standard nf-core modules, which require that they are available in conda. In order to create the conda environment for these modules we first need pio to be available on conda-forge, but did not necessarily plan to submit pio to CRAN since nowadays there are similar packages available. Pio is stable, if it helps, with no need for updates in the past 5 years even with all of our other packages being dependent on it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend submitting this to Bioconda instead. You can also ping me there for review/merge.

CC: @conda-forge/bioconda-recipes

@@ -0,0 +1,63 @@
{% set name = "r-pio" %}
{% set version = "v1.0.0" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tag shows v1.0.0, but the DESCRIPTION file shows v0.1.0.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, I will bump the version number and repackage

@mfansler
Copy link
Member

mfansler commented Apr 9, 2025

Closing, since this is merged on Bioconda (bioconda/bioconda-recipes#55213).

@mfansler mfansler closed this Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants