Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ismrmrd-python package #25854

Merged
merged 2 commits into from
Mar 27, 2024
Merged

add ismrmrd-python package #25854

merged 2 commits into from
Mar 27, 2024

Conversation

gabuzi
Copy link
Contributor

@gabuzi gabuzi commented Mar 24, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

xref ismrmrd/ismrmrd-python#69

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ismrmrd-python) and found it was in an excellent condition.

@gabuzi
Copy link
Contributor Author

gabuzi commented Mar 25, 2024

I was successfully able to build & test this on a windows box. Retrying CI
@conda-forge-admin, please restart ci

@gabuzi
Copy link
Contributor Author

gabuzi commented Mar 25, 2024

@conda-forge-admin, please ping team

Hi, are there any insights into MemoryErrors on conda-forge CI infra?
I can successfully build & test this on a windows box with conda reporting a max memory use of few 100 MiB. Also, the arrays involved in the test are small (couple of 1000 elements), and the offending operation doesn't actually use them. I can't see how this could be a real error...

Can we still proceed?

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@ocefpaf
Copy link
Member

ocefpaf commented Mar 27, 2024

Can we still proceed?

B/c this is noarch yes, we can proceed and the package will be built and test on Linux but available to all archs. However, if you want to make sure most of the tests passes on Windows anyway, you can skip that one. This is not mandatory to merge though and I would recommend you to tinker with this later.

@ocefpaf ocefpaf merged commit f812fb7 into conda-forge:main Mar 27, 2024
3 of 5 checks passed
@gabuzi
Copy link
Contributor Author

gabuzi commented Mar 27, 2024

Can we still proceed?

B/c this is noarch yes, we can proceed and the package will be built and test on Linux but available to all archs. However, if you want to make sure most of the tests passes on Windows anyway, you can skip that one. This is not mandatory to merge though and I would recommend you to tinker with this later.

Thanks a lot for the review & merge! I will look into ironing out those in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants