Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a constraint in openff-toolkit-base #958

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mattwthompson
Copy link
Member

I screwed up a release because I didn't double-check everything - my bad! - hopefully the change I'm after here is straightforward enough

  • Used a static YAML file for the patch if possible (instructions).
  • Only wrote code directly into generate_patch_json.py if absolutely necessary.
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.

Here's the local diff:

$ python recipe/show_diff.py --subdirs noarch --use-cache                                  15:24:08  ☁  openff-toolkit-units ☀
================================================================================
================================================================================
noarch
noarch::openff-toolkit-base-0.11.3-pyhd8ed1ab_0.tar.bz2
noarch::openff-toolkit-base-0.11.4-pyhd8ed1ab_0.tar.bz2
noarch::openff-toolkit-base-0.11.4-pyhd8ed1ab_1.conda
noarch::openff-toolkit-base-0.12.0-pyhd8ed1ab_0.conda
noarch::openff-toolkit-base-0.12.1-pyhd8ed1ab_0.conda
noarch::openff-toolkit-base-0.12.1-pyhd8ed1ab_1.conda
noarch::openff-toolkit-base-0.12.1-pyhd8ed1ab_2.conda
noarch::openff-toolkit-base-0.13.0-pyhd8ed1ab_0.conda
noarch::openff-toolkit-base-0.13.1-pyhd8ed1ab_0.conda
noarch::openff-toolkit-base-0.13.2-pyhd8ed1ab_0.conda
noarch::openff-toolkit-base-0.14.0-pyhd8ed1ab_0.conda
noarch::openff-toolkit-base-0.14.0-pyhd8ed1ab_1.conda
noarch::openff-toolkit-base-0.14.0-pyhd8ed1ab_2.conda
noarch::openff-toolkit-base-0.14.0-pyhd8ed1ab_3.conda
noarch::openff-toolkit-base-0.14.0-pyhd8ed1ab_4.conda
noarch::openff-toolkit-base-0.14.1-pyhd8ed1ab_0.conda
noarch::openff-toolkit-base-0.14.2-pyhd8ed1ab_0.conda
noarch::openff-toolkit-base-0.14.3-pyhd8ed1ab_0.conda
noarch::openff-toolkit-base-0.14.5-pyhd8ed1ab_1.conda
noarch::openff-toolkit-base-0.15.0-pyhd8ed1ab_0.conda
noarch::openff-toolkit-base-0.15.0-pyhd8ed1ab_1.conda
noarch::openff-toolkit-base-0.15.1-pyhd8ed1ab_0.conda
noarch::openff-toolkit-base-0.15.2-pyhd8ed1ab_0.conda
noarch::openff-toolkit-base-0.16.0-pyhd8ed1ab_0.conda
noarch::openff-toolkit-base-0.16.0-pyhd8ed1ab_1.conda
noarch::openff-toolkit-base-0.16.1-pyhd8ed1ab_0.conda
noarch::openff-toolkit-base-0.16.1-pyhd8ed1ab_1.conda
noarch::openff-toolkit-base-0.16.2-pyhd8ed1ab_0.conda
noarch::openff-toolkit-base-0.16.3-pyhd8ed1ab_0.conda
noarch::openff-toolkit-base-0.16.4-pyhd8ed1ab_0.conda
noarch::openff-toolkit-base-0.16.5-pyhd8ed1ab_0.conda
noarch::openff-toolkit-base-0.16.6-pyhd8ed1ab_0.conda
noarch::openff-toolkit-base-0.16.7-pyhd8ed1ab_0.conda
-    "openff-units >=0.2.0",
+    "openff-units ~=0.2.0",
noarch::openff-units-0.3.0-pyhd8ed1ab_0.conda
-    "pint =0.24,<0.24.5",
+    "pint ==0.24,<0.24.5.*",

@mattwthompson mattwthompson changed the title Openff toolkit units Fix a constraint in openff-toolkit-base Feb 6, 2025
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@mattwthompson mattwthompson marked this pull request as ready for review February 6, 2025 21:42
@mattwthompson mattwthompson requested a review from a team as a code owner February 6, 2025 21:42
@mattwthompson
Copy link
Member Author

CI looks to be getting the same results as local

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants